Re: [Qemu-devel] [PATCH 1/2] qga-win: prevent crash when executing fsinfo command

2018-07-16 Thread Sameeh Jubran
I've found another bug which is related to this one, where pci_controller might also be null: in the function "build_guest_disk_info" in "qga/commands-win32.c" if (bus == BusTypeScsi || bus == BusTypeAta || bus == BusTypeRAID #if (_WIN32_WINNT >= 0x0600) /* This bus type is not supported before

Re: [Qemu-devel] [PATCH 1/2] qga-win: prevent crash when executing fsinfo command

2018-07-09 Thread Michael Roth
Quoting Sameeh Jubran (2018-06-28 18:33:58) > > > On Fri, Jun 29, 2018 at 12:44 AM, Eric Blake wrote: > > On 06/26/2018 10:10 AM, Sameeh Jubran wrote: > > From: Sameeh Jubran > > The fsinfo command is currently implemented for Windows only and it's > disk >

Re: [Qemu-devel] [PATCH 1/2] qga-win: prevent crash when executing fsinfo command

2018-06-28 Thread Sameeh Jubran
On Fri, Jun 29, 2018 at 12:44 AM, Eric Blake wrote: > On 06/26/2018 10:10 AM, Sameeh Jubran wrote: > >> From: Sameeh Jubran >> >> The fsinfo command is currently implemented for Windows only and it's disk >> parameter can be enabled by adding the define "CONFIG_QGA_NTDDSCSI" to >> the qga >> cod

Re: [Qemu-devel] [PATCH 1/2] qga-win: prevent crash when executing fsinfo command

2018-06-28 Thread Eric Blake
On 06/26/2018 10:10 AM, Sameeh Jubran wrote: From: Sameeh Jubran The fsinfo command is currently implemented for Windows only and it's disk parameter can be enabled by adding the define "CONFIG_QGA_NTDDSCSI" to the qga code. When enabled and executed the qemu-ga crashed with the following messa

Re: [Qemu-devel] [PATCH 1/2] qga-win: prevent crash when executing fsinfo command

2018-06-26 Thread Philippe Mathieu-Daudé
On 06/26/2018 12:10 PM, Sameeh Jubran wrote: > From: Sameeh Jubran > > The fsinfo command is currently implemented for Windows only and it's disk > parameter can be enabled by adding the define "CONFIG_QGA_NTDDSCSI" to the qga > code. When enabled and executed the qemu-ga crashed with the followi

[Qemu-devel] [PATCH 1/2] qga-win: prevent crash when executing fsinfo command

2018-06-26 Thread Sameeh Jubran
From: Sameeh Jubran The fsinfo command is currently implemented for Windows only and it's disk parameter can be enabled by adding the define "CONFIG_QGA_NTDDSCSI" to the qga code. When enabled and executed the qemu-ga crashed with the following message: --