Re: [Qemu-devel] [PATCH 1/2] qemu-img: Report bdrv_block_status failures

2019-03-25 Thread Eric Blake
On 3/25/19 6:53 AM, Kevin Wolf wrote: > Am 25.03.2019 um 11:27 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 24.03.2019 0:26, Eric Blake wrote: >>> If bdrv_block_status_above() fails, we are aborting the convert >>> process but failing to print an error message. Broken in commit >>> 690c7301 (v

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Report bdrv_block_status failures

2019-03-25 Thread Kevin Wolf
Am 25.03.2019 um 11:27 hat Vladimir Sementsov-Ogievskiy geschrieben: > 24.03.2019 0:26, Eric Blake wrote: > > If bdrv_block_status_above() fails, we are aborting the convert > > process but failing to print an error message. Broken in commit > > 690c7301 (v2.4) when rewriting convert's logic. > >

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Report bdrv_block_status failures

2019-03-25 Thread Vladimir Sementsov-Ogievskiy
25.03.2019 13:27, Vladimir Sementsov-Ogievskiy wrote: > 24.03.2019 0:26, Eric Blake wrote: >> If bdrv_block_status_above() fails, we are aborting the convert >> process but failing to print an error message.  Broken in commit >> 690c7301 (v2.4) when rewriting convert's logic. >> >> Discovered when

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Report bdrv_block_status failures

2019-03-25 Thread Vladimir Sementsov-Ogievskiy
24.03.2019 0:26, Eric Blake wrote: > If bdrv_block_status_above() fails, we are aborting the convert > process but failing to print an error message. Broken in commit > 690c7301 (v2.4) when rewriting convert's logic. > > Discovered when teaching nbdkit to support NBD_CMD_BLOCK_STATUS, and > accid

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Report bdrv_block_status failures

2019-03-25 Thread Kevin Wolf
Am 23.03.2019 um 22:26 hat Eric Blake geschrieben: > If bdrv_block_status_above() fails, we are aborting the convert > process but failing to print an error message. Broken in commit > 690c7301 (v2.4) when rewriting convert's logic. > > Discovered when teaching nbdkit to support NBD_CMD_BLOCK_STA

[Qemu-devel] [PATCH 1/2] qemu-img: Report bdrv_block_status failures

2019-03-23 Thread Eric Blake
If bdrv_block_status_above() fails, we are aborting the convert process but failing to print an error message. Broken in commit 690c7301 (v2.4) when rewriting convert's logic. Discovered when teaching nbdkit to support NBD_CMD_BLOCK_STATUS, and accidentally violating the protocol by returning mor