Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-19 Thread Laszlo Ersek
On 06/19/13 15:39, Stefano Stabellini wrote: > On Mon, 17 Jun 2013, Laszlo Ersek wrote: >> On 06/17/13 11:57, Michael S. Tsirkin wrote: >>> On Mon, Jun 17, 2013 at 11:35:00AM +0200, Laszlo Ersek wrote: On 06/17/13 11:19, Michael S. Tsirkin wrote: > On Mon, Jun 17, 2013 at 09:56:56AM +0200,

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-19 Thread Stefano Stabellini
On Mon, 17 Jun 2013, Laszlo Ersek wrote: > On 06/17/13 11:57, Michael S. Tsirkin wrote: > > On Mon, Jun 17, 2013 at 11:35:00AM +0200, Laszlo Ersek wrote: > >> On 06/17/13 11:19, Michael S. Tsirkin wrote: > >>> On Mon, Jun 17, 2013 at 09:56:56AM +0200, Laszlo Ersek wrote: > On 06/16/13 22:59, M

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-19 Thread Stefano Stabellini
On Mon, 17 Jun 2013, Michael S. Tsirkin wrote: > On Mon, Jun 17, 2013 at 11:35:00AM +0200, Laszlo Ersek wrote: > > On 06/17/13 11:19, Michael S. Tsirkin wrote: > > > On Mon, Jun 17, 2013 at 09:56:56AM +0200, Laszlo Ersek wrote: > > >> On 06/16/13 22:59, Michael S. Tsirkin wrote: > > >>> Avoid use o

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-19 Thread Stefano Stabellini
On Mon, 17 Jun 2013, Laszlo Ersek wrote: > On 06/17/13 11:19, Michael S. Tsirkin wrote: > > On Mon, Jun 17, 2013 at 09:56:56AM +0200, Laszlo Ersek wrote: > >> On 06/16/13 22:59, Michael S. Tsirkin wrote: > >>> Avoid use of static variables: PC systems initialize pvpanic device > >>> through pvpanic

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-17 Thread Laszlo Ersek
On 06/17/13 11:57, Michael S. Tsirkin wrote: > On Mon, Jun 17, 2013 at 11:35:00AM +0200, Laszlo Ersek wrote: >> On 06/17/13 11:19, Michael S. Tsirkin wrote: >>> On Mon, Jun 17, 2013 at 09:56:56AM +0200, Laszlo Ersek wrote: On 06/16/13 22:59, Michael S. Tsirkin wrote: > Avoid use of static

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2013 at 11:35:00AM +0200, Laszlo Ersek wrote: > On 06/17/13 11:19, Michael S. Tsirkin wrote: > > On Mon, Jun 17, 2013 at 09:56:56AM +0200, Laszlo Ersek wrote: > >> On 06/16/13 22:59, Michael S. Tsirkin wrote: > >>> Avoid use of static variables: PC systems initialize pvpanic device

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-17 Thread Laszlo Ersek
On 06/17/13 11:19, Michael S. Tsirkin wrote: > On Mon, Jun 17, 2013 at 09:56:56AM +0200, Laszlo Ersek wrote: >> On 06/16/13 22:59, Michael S. Tsirkin wrote: >>> Avoid use of static variables: PC systems initialize pvpanic device >>> through pvpanic_init, so we can simply create the fw_cfg file at t

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2013 at 09:56:56AM +0200, Laszlo Ersek wrote: > On 06/16/13 22:59, Michael S. Tsirkin wrote: > > Avoid use of static variables: PC systems initialize pvpanic device > > through pvpanic_init, so we can simply create the fw_cfg file at that > > point. Others don't use fw_cfg at all.

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-17 Thread Laszlo Ersek
On 06/16/13 22:59, Michael S. Tsirkin wrote: > Avoid use of static variables: PC systems initialize pvpanic device > through pvpanic_init, so we can simply create the fw_cfg file at that > point. Others don't use fw_cfg at all. This also makes it possible to > assert if fw_cfg is not there rather

[Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-16 Thread Michael S. Tsirkin
Avoid use of static variables: PC systems initialize pvpanic device through pvpanic_init, so we can simply create the fw_cfg file at that point. Others don't use fw_cfg at all. This also makes it possible to assert if fw_cfg is not there rather than skipping the device silently. Signed-off-by: M