Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful

2011-08-24 Thread Avi Kivity
On 08/24/2011 04:02 PM, Anthony Liguori wrote: Too subtle, IMO. I understand that we want to avoid a full qmp parser for one-off unit tests, but using bit fields in the exit code? Perhaps a python script that launches qemu with qmp and -no-shutdown, listens for the guest shutdown event, and prin

Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful

2011-08-24 Thread Anthony Liguori
On 08/24/2011 07:55 AM, Avi Kivity wrote: On 08/24/2011 03:38 PM, Anthony Liguori wrote: diff --git a/hw/pc.c b/hw/pc.c index 1c9d89a..4b07b35 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -549,8 +549,7 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val) /* LGPL'ed VGA BIOS mes

Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful

2011-08-24 Thread Avi Kivity
On 08/24/2011 03:38 PM, Anthony Liguori wrote: diff --git a/hw/pc.c b/hw/pc.c index 1c9d89a..4b07b35 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -549,8 +549,7 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val) /* LGPL'ed VGA BIOS messages */ case 0x501: case 0x502: - fprintf(

Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful

2011-08-24 Thread Anthony Liguori
On 08/24/2011 04:47 AM, Avi Kivity wrote: On 08/08/2011 10:31 PM, Anthony Liguori wrote: We've always listened on port 501 for vgabios panic messages. In the entire time I've worked on QEMU, I've never actually seen a vgabios panic message :-) If we change the semantics of this port a little bi

Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful

2011-08-24 Thread Avi Kivity
On 08/08/2011 10:31 PM, Anthony Liguori wrote: We've always listened on port 501 for vgabios panic messages. In the entire time I've worked on QEMU, I've never actually seen a vgabios panic message :-) If we change the semantics of this port a little bit, it makes it possible to use it for more

Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful

2011-08-12 Thread Anthony Liguori
On 08/08/2011 02:31 PM, Anthony Liguori wrote: We've always listened on port 501 for vgabios panic messages. In the entire time I've worked on QEMU, I've never actually seen a vgabios panic message :-) If we change the semantics of this port a little bit, it makes it possible to use it for more

[Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful

2011-08-08 Thread Anthony Liguori
We've always listened on port 501 for vgabios panic messages. In the entire time I've worked on QEMU, I've never actually seen a vgabios panic message :-) If we change the semantics of this port a little bit, it makes it possible to use it for more interesting use-cases. I chose this approach in