Re: [Qemu-devel] [PATCH 1/2] oslib-win32: add lock for gmtime_r()

2013-01-09 Thread Stefan Weil
>>> Il 09/01/2013 07:18, Wenchao Xia ha scritto: Also changed the caller of gmtime() to gmtime_r(). >>> >>> Should be a separate patch. >> >> There is already a pending patch which replaces gmtime, localtime: >> >> http://patchwork.ozlabs.org/patch/210250/ >> >> Stefan >> >> >Should oth

Re: [Qemu-devel] [PATCH 1/2] oslib-win32: add lock for gmtime_r()

2013-01-09 Thread Wenchao Xia
于 2013-1-10 1:06, Stefan Weil 写道: Il 09/01/2013 07:18, Wenchao Xia ha scritto: Also changed the caller of gmtime() to gmtime_r(). Should be a separate patch. There is already a pending patch which replaces gmtime, localtime: http://patchwork.ozlabs.org/patch/210250/ Stefan Should o

Re: [Qemu-devel] [PATCH 1/2] oslib-win32: add lock for gmtime_r()

2013-01-09 Thread Wenchao Xia
于 2013-1-9 17:47, Paolo Bonzini 写道: Il 09/01/2013 07:18, Wenchao Xia ha scritto: Also changed the caller of gmtime() to gmtime_r(). Should be a separate patch. Also, what is the reason to add this lock? They are already protected by the BQL. Paolo localtime_r() will be used in interna

Re: [Qemu-devel] [PATCH 1/2] oslib-win32: add lock for gmtime_r()

2013-01-09 Thread Stefan Weil
> Il 09/01/2013 07:18, Wenchao Xia ha scritto: >> Also changed the caller of gmtime() to gmtime_r(). > > Should be a separate patch. There is already a pending patch which replaces gmtime, localtime: http://patchwork.ozlabs.org/patch/210250/ Stefan

Re: [Qemu-devel] [PATCH 1/2] oslib-win32: add lock for gmtime_r()

2013-01-09 Thread Paolo Bonzini
Il 09/01/2013 07:18, Wenchao Xia ha scritto: > Also changed the caller of gmtime() to gmtime_r(). Should be a separate patch. Also, what is the reason to add this lock? They are already protected by the BQL. Paolo > Signed-off-by: Wenchao Xia > --- > oslib-win32.c |6 +- > vl.c

[Qemu-devel] [PATCH 1/2] oslib-win32: add lock for gmtime_r()

2013-01-08 Thread Wenchao Xia
Also changed the caller of gmtime() to gmtime_r(). Signed-off-by: Wenchao Xia --- oslib-win32.c |6 +- vl.c |4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/oslib-win32.c b/oslib-win32.c index e7e283e..74e0c52 100644 --- a/oslib-win32.c +++ b/oslib-w