Re: [Qemu-devel] [PATCH 1/2] niagara: fail if a firmware file is missing

2017-01-24 Thread Peter Maydell
On 24 January 2017 at 08:21, Markus Armbruster wrote: > Peter Maydell writes: >> PS: doesn't this break 'make check' if the rom files >> are missing? > > Yes, it does. Obvious incremental fix appended. It still prints > rom_add_file()'s message. Swap the operands of && to get rid of it. Yes,

Re: [Qemu-devel] [PATCH 1/2] niagara: fail if a firmware file is missing

2017-01-24 Thread Artyom Tarasenko
On Tue, Jan 24, 2017 at 9:21 AM, Markus Armbruster wrote: > Peter Maydell writes: > >> On 23 January 2017 at 22:17, Peter Maydell wrote: >>> On 23 January 2017 at 21:21, Artyom Tarasenko wrote: Suggested-by: Peter Maydell Signed-off-by: Artyom Tarasenko --- hw/sparc64/nia

Re: [Qemu-devel] [PATCH 1/2] niagara: fail if a firmware file is missing

2017-01-24 Thread Markus Armbruster
Peter Maydell writes: > On 23 January 2017 at 22:17, Peter Maydell wrote: >> On 23 January 2017 at 21:21, Artyom Tarasenko wrote: >>> Suggested-by: Peter Maydell >>> Signed-off-by: Artyom Tarasenko >>> --- >>> hw/sparc64/niagara.c | 22 +++--- >>> 1 file changed, 15 insertion

Re: [Qemu-devel] [PATCH 1/2] niagara: fail if a firmware file is missing

2017-01-23 Thread Peter Maydell
On 23 January 2017 at 21:21, Artyom Tarasenko wrote: > Suggested-by: Peter Maydell > Signed-off-by: Artyom Tarasenko > --- > hw/sparc64/niagara.c | 22 +++--- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/hw/sparc64/niagara.c b/hw/sparc64/niagara.c > index

Re: [Qemu-devel] [PATCH 1/2] niagara: fail if a firmware file is missing

2017-01-23 Thread Peter Maydell
On 23 January 2017 at 22:17, Peter Maydell wrote: > On 23 January 2017 at 21:21, Artyom Tarasenko wrote: >> Suggested-by: Peter Maydell >> Signed-off-by: Artyom Tarasenko >> --- >> hw/sparc64/niagara.c | 22 +++--- >> 1 file changed, 15 insertions(+), 7 deletions(-) >> >> diff

[Qemu-devel] [PATCH 1/2] niagara: fail if a firmware file is missing

2017-01-23 Thread Artyom Tarasenko
Suggested-by: Peter Maydell Signed-off-by: Artyom Tarasenko --- hw/sparc64/niagara.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/hw/sparc64/niagara.c b/hw/sparc64/niagara.c index b55d4bb..e945b5a 100644 --- a/hw/sparc64/niagara.c +++ b/hw/sparc64/n