Re: [Qemu-devel] [PATCH 1/2] monitor: Split mon_get_cpu fn to remove ENV_GET_CPU

2015-05-24 Thread Peter Crosthwaite
On Mon, May 18, 2015 at 9:52 AM, Andreas Färber wrote: > Am 18.05.2015 um 18:44 schrieb Peter Crosthwaite: >> On Mon, May 18, 2015 at 9:13 AM, Richard Henderson wrote: >>> On 05/17/2015 12:51 PM, Peter Crosthwaite wrote: @@ -1208,7 +1203,6 @@ static void monitor_printc(Monitor *mon, int c) >

Re: [Qemu-devel] [PATCH 1/2] monitor: Split mon_get_cpu fn to remove ENV_GET_CPU

2015-05-18 Thread Andreas Färber
Am 18.05.2015 um 18:44 schrieb Peter Crosthwaite: > On Mon, May 18, 2015 at 9:13 AM, Richard Henderson wrote: >> On 05/17/2015 12:51 PM, Peter Crosthwaite wrote: >>> @@ -1208,7 +1203,6 @@ static void monitor_printc(Monitor *mon, int c) >>> static void memory_dump(Monitor *mon, int count, int form

Re: [Qemu-devel] [PATCH 1/2] monitor: Split mon_get_cpu fn to remove ENV_GET_CPU

2015-05-18 Thread Peter Crosthwaite
On Mon, May 18, 2015 at 9:13 AM, Richard Henderson wrote: > On 05/17/2015 12:51 PM, Peter Crosthwaite wrote: >> @@ -1208,7 +1203,6 @@ static void monitor_printc(Monitor *mon, int c) >> static void memory_dump(Monitor *mon, int count, int format, int wsize, >> hwaddr addr,

Re: [Qemu-devel] [PATCH 1/2] monitor: Split mon_get_cpu fn to remove ENV_GET_CPU

2015-05-18 Thread Richard Henderson
On 05/17/2015 12:51 PM, Peter Crosthwaite wrote: > @@ -1208,7 +1203,6 @@ static void monitor_printc(Monitor *mon, int c) > static void memory_dump(Monitor *mon, int count, int format, int wsize, > hwaddr addr, int is_physical) > { > -CPUArchState *env; > int l, l

[Qemu-devel] [PATCH 1/2] monitor: Split mon_get_cpu fn to remove ENV_GET_CPU

2015-05-17 Thread Peter Crosthwaite
The monitor currently has one helper, mon_get_cpu() which will return an env pointer. The target specific users of this API want an env, but all the target agnostic users really just want the cpu pointer. These users then need to use the target-specifically defined ENV_GET_CPU to navigate back up t