Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

2017-03-06 Thread Paolo Bonzini
On 01/03/2017 21:20, John Snow wrote: > we have an idebus unrealize function, but it was being registered as the > unrealize function for the IDE Device, so it was not getting invoked on > device teardown because nothing is "unrealizing" the IDE devices > themselves, AFAIK. I agree. Thanks for

Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

2017-03-01 Thread John Snow
On 02/28/2017 08:03 PM, Li Qiang wrote: > Hello John, Paolo, > > 2017-03-01 8:47 GMT+08:00 John Snow >: > > > > On 02/09/2017 02:04 AM, Li Qiang wrote: > > As the pci ahci can be hotplug and unplug, in the ahci unrealize > > function it should free all th

Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

2017-02-28 Thread Li Qiang
Hello John, Paolo, 2017-03-01 8:47 GMT+08:00 John Snow : > > > On 02/09/2017 02:04 AM, Li Qiang wrote: > > As the pci ahci can be hotplug and unplug, in the ahci unrealize > > function it should free all the resource once allocated in the > > realized function. This patch adds two cleanup functio

Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

2017-02-28 Thread John Snow
On 02/09/2017 02:04 AM, Li Qiang wrote: > As the pci ahci can be hotplug and unplug, in the ahci unrealize > function it should free all the resource once allocated in the > realized function. This patch adds two cleanup function. > So, the peculiarities of the current arrangement of QDEV reali

Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

2017-02-15 Thread John Snow
On 02/15/2017 04:26 AM, Li Qiang wrote: > Hello, > > 2017-02-15 7:30 GMT+08:00 John Snow >: > > > > On 02/09/2017 08:22 PM, Li Qiang wrote: > > Hello John, > > > > 2017-02-10 3:42 GMT+08:00 John Snow > >

Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

2017-02-15 Thread Li Qiang
Hello, 2017-02-15 7:30 GMT+08:00 John Snow : > > > On 02/09/2017 08:22 PM, Li Qiang wrote: > > Hello John, > > > > 2017-02-10 3:42 GMT+08:00 John Snow > >: > > > > > > > > On 02/09/2017 02:04 AM, Li Qiang wrote: > > > As the pci ahci can be hotplug and unplug, in

Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

2017-02-14 Thread John Snow
On 02/09/2017 08:22 PM, Li Qiang wrote: > Hello John, > > 2017-02-10 3:42 GMT+08:00 John Snow >: > > > > On 02/09/2017 02:04 AM, Li Qiang wrote: > > As the pci ahci can be hotplug and unplug, in the ahci unrealize > > function it should free all the resou

Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

2017-02-09 Thread Li Qiang
Hello John, 2017-02-10 3:42 GMT+08:00 John Snow : > > > On 02/09/2017 02:04 AM, Li Qiang wrote: > > As the pci ahci can be hotplug and unplug, in the ahci unrealize > > function it should free all the resource once allocated in the > > realized function. This patch adds two cleanup function. > >

Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

2017-02-09 Thread John Snow
On 02/09/2017 02:04 AM, Li Qiang wrote: > As the pci ahci can be hotplug and unplug, in the ahci unrealize > function it should free all the resource once allocated in the > realized function. This patch adds two cleanup function. > > Signed-off-by: Li Qiang > --- > hw/ide/core.c |

[Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

2017-02-08 Thread Li Qiang
As the pci ahci can be hotplug and unplug, in the ahci unrealize function it should free all the resource once allocated in the realized function. This patch adds two cleanup function. Signed-off-by: Li Qiang --- hw/ide/core.c | 21 + include/hw/ide/internal.h |