On 4/12/19 1:55 PM, Peter Maydell wrote:
> On Fri, 12 Apr 2019 at 04:17, Joel Stanley wrote:
>> vmstate and migration is a foreign concept for the small ARM machines.
>> As well as being a developer, I am an end user of Qemu for them (the
>> aspeeds, microbit), and the use case is to boot up a fir
On Fri, 12 Apr 2019 at 04:17, Joel Stanley wrote:
> vmstate and migration is a foreign concept for the small ARM machines.
> As well as being a developer, I am an end user of Qemu for them (the
> aspeeds, microbit), and the use case is to boot up a firmware and
> check that it does correct thing.
Thanks for the review Peter and Cedric.
On Thu, 11 Apr 2019 at 15:30, Cédric Le Goater wrote:
>
> On 4/11/19 5:25 PM, Peter Maydell wrote:
> >> +
> >> +#define COUNTER1(0x00 / 4)
> >> +#define COUNTER2(0x04 / 4)
> >> +#define ALARM (0x08 / 4)
> >> +#define CONTROL
On Thu, 11 Apr 2019 at 17:37, Philippe Mathieu-Daudé wrote:
>
> Hi Peter,
>
> On 4/11/19 5:30 PM, Cédric Le Goater wrote:
> > On 4/11/19 5:25 PM, Peter Maydell wrote:
> >> This is missing a reset function and vmstate.
>
> Is vmstate mandatory for new devices.
Yes, I think so. You can have vmstate
Hi Peter,
On 4/11/19 5:30 PM, Cédric Le Goater wrote:
> On 4/11/19 5:25 PM, Peter Maydell wrote:
>> On Thu, 28 Mar 2019 at 06:22, Joel Stanley wrote:
>>>
>>> Signed-off-by: Joel Stanley
>>> Signed-off-by: Cédric Le Goater
>>> ---
>>> hw/timer/Makefile.objs| 2 +-
>>> hw/timer/aspeed_
On 4/11/19 5:25 PM, Peter Maydell wrote:
> On Thu, 28 Mar 2019 at 06:22, Joel Stanley wrote:
>>
>> Signed-off-by: Joel Stanley
>> Signed-off-by: Cédric Le Goater
>> ---
>> hw/timer/Makefile.objs| 2 +-
>> hw/timer/aspeed_rtc.c | 157 ++
>> hw/ti
On Thu, 28 Mar 2019 at 06:22, Joel Stanley wrote:
>
> Signed-off-by: Joel Stanley
> Signed-off-by: Cédric Le Goater
> ---
> hw/timer/Makefile.objs| 2 +-
> hw/timer/aspeed_rtc.c | 157 ++
> hw/timer/trace-events | 4 +
> include/hw/tim
Signed-off-by: Joel Stanley
Signed-off-by: Cédric Le Goater
---
hw/timer/Makefile.objs| 2 +-
hw/timer/aspeed_rtc.c | 157 ++
hw/timer/trace-events | 4 +
include/hw/timer/aspeed_rtc.h | 31 +++
4 files changed, 193 insertions(+),