Re: [Qemu-devel] [PATCH 1/2] hw/sd: Add medium insertion status

2016-01-07 Thread Max Reitz
On 07.01.2016 22:45, Peter Maydell wrote: > On 7 January 2016 at 21:03, Max Reitz wrote: >> Right now, the change_media_cb (sd_cardchange()) completely ignores its >> @load parameter. This means that issuing a blockdev-open-tray command >> will actually not have any effect. >> >> Fix this by keepi

Re: [Qemu-devel] [PATCH 1/2] hw/sd: Add medium insertion status

2016-01-07 Thread Peter Maydell
On 7 January 2016 at 21:03, Max Reitz wrote: > Right now, the change_media_cb (sd_cardchange()) completely ignores its > @load parameter. This means that issuing a blockdev-open-tray command > will actually not have any effect. > > Fix this by keeping track of the medium insertion status in the SD

Re: [Qemu-devel] [PATCH 1/2] hw/sd: Add medium insertion status

2016-01-07 Thread John Snow
On 01/07/2016 04:03 PM, Max Reitz wrote: > Right now, the change_media_cb (sd_cardchange()) completely ignores its > @load parameter. This means that issuing a blockdev-open-tray command > will actually not have any effect. > > Fix this by keeping track of the medium insertion status in the SDSt

[Qemu-devel] [PATCH 1/2] hw/sd: Add medium insertion status

2016-01-07 Thread Max Reitz
Right now, the change_media_cb (sd_cardchange()) completely ignores its @load parameter. This means that issuing a blockdev-open-tray command will actually not have any effect. Fix this by keeping track of the medium insertion status in the SDState and updating it in sd_init() and sd_cardchange().