On 20 April 2018 at 15:29, Philippe Mathieu-Daudé wrote:
On 04/20/2018 05:43 AM, Peter Maydell wrote:
Since we can now safely call serial_mm_init(..., chr=NULL, ...), I'll
work on simplifying and fixing this.
>>>
>>> Correct. There are a bunch of dubious workarounds in the
>>> codeb
>>> On 04/20/2018 05:43 AM, Peter Maydell wrote:
>>> Since we can now safely call serial_mm_init(..., chr=NULL, ...), I'll
>>> work on simplifying and fixing this.
>>
>> Correct. There are a bunch of dubious workarounds in the
>> codebase which try to handle the problem at different levels,
>> but
On 20 April 2018 at 14:04, Philippe Mathieu-Daudé wrote:
> On 04/20/2018 09:59 AM, Peter Maydell wrote:
>> Incidentally I was wondering if we could sensibly get rid of
>> the compile time MAX_SERIAL_PORTS. Right now there's no way
>> to model a device with five UARTs such that they can all
>> be s
On 04/20/2018 09:59 AM, Peter Maydell wrote:
> On 20 April 2018 at 13:39, Philippe Mathieu-Daudé wrote:
>> On 04/20/2018 05:43 AM, Peter Maydell wrote:
>>> On 19 April 2018 at 23:09, Philippe Mathieu-Daudé wrote:
4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent
use o
On 20 April 2018 at 13:39, Philippe Mathieu-Daudé wrote:
> Hi Peter,
>
> On 04/20/2018 05:43 AM, Peter Maydell wrote:
>> On 19 April 2018 at 23:09, Philippe Mathieu-Daudé wrote:
>>> 4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent
>>> use of Chardev->be. Also, this CharBackend
Hi Peter,
On 04/20/2018 05:43 AM, Peter Maydell wrote:
> On 19 April 2018 at 23:09, Philippe Mathieu-Daudé wrote:
>> 4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent
>> use of Chardev->be. Also, this CharBackend member is private and is
>> not supposed to be accessible.
>>
>>
On 19 April 2018 at 23:09, Philippe Mathieu-Daudé wrote:
> 4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent
> use of Chardev->be. Also, this CharBackend member is private and is
> not supposed to be accessible.
>
> Fix it by removing the inconsistent check.
>
> Reported-by: Mar
4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent
use of Chardev->be. Also, this CharBackend member is private and is
not supposed to be accessible.
Fix it by removing the inconsistent check.
Reported-by: Marc-André Lureau
Signed-off-by: Philippe Mathieu-Daudé
---
hw/isa/isa
