Re: [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage

2012-08-01 Thread Avi Kivity
On 07/26/2012 01:45 AM, Tyler Hall wrote: > subpage_register() expects "end" to be the last byte in the mapping. > Registering a non-page-aligned memory region that extends up to or > beyond a page boundary causes subpage_register() to silently fail > through the (end >= PAGE_SIZE) check. > > This

Re: [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage

2012-08-01 Thread Avi Kivity
On 08/01/2012 04:01 PM, Stefan Hajnoczi wrote: > On Wed, Aug 1, 2012 at 1:56 PM, Avi Kivity wrote: >> On 07/26/2012 01:45 AM, Tyler Hall wrote: >>> subpage_register() expects "end" to be the last byte in the mapping. >>> Registering a non-page-aligned memory region that extends up to or >>> beyond

Re: [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage

2012-08-01 Thread Stefan Hajnoczi
On Wed, Aug 1, 2012 at 1:56 PM, Avi Kivity wrote: > On 07/26/2012 01:45 AM, Tyler Hall wrote: >> subpage_register() expects "end" to be the last byte in the mapping. >> Registering a non-page-aligned memory region that extends up to or >> beyond a page boundary causes subpage_register() to silentl

[Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage

2012-07-25 Thread Tyler Hall
subpage_register() expects "end" to be the last byte in the mapping. Registering a non-page-aligned memory region that extends up to or beyond a page boundary causes subpage_register() to silently fail through the (end >= PAGE_SIZE) check. This bug does not cause noticeable problems for mappings t