Re: [Qemu-devel] [PATCH 1/2] dma-helpers: Initialize DMAAIOCB in_cancel flag

2014-04-04 Thread Kevin Wolf
Am 28.03.2014 um 15:22 hat Peter Maydell geschrieben: > Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get() > does not return zero-initialized memory. Spotted by the clang sanitizer > (which complained when the value loaded in dma_complete() was not valid > for a bool type); t

Re: [Qemu-devel] [PATCH 1/2] dma-helpers: Initialize DMAAIOCB in_cancel flag

2014-04-04 Thread Stefan Hajnoczi
On Fri, Mar 28, 2014 at 02:22:49PM +, Peter Maydell wrote: > Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get() > does not return zero-initialized memory. Spotted by the clang sanitizer > (which complained when the value loaded in dma_complete() was not valid > for a bool

Re: [Qemu-devel] [PATCH 1/2] dma-helpers: Initialize DMAAIOCB in_cancel flag

2014-04-03 Thread Peter Maydell
On 28 March 2014 14:22, Peter Maydell wrote: > Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get() > does not return zero-initialized memory. Spotted by the clang sanitizer > (which complained when the value loaded in dma_complete() was not valid > for a bool type); this migh

Re: [Qemu-devel] [PATCH 1/2] dma-helpers: Initialize DMAAIOCB in_cancel flag

2014-03-28 Thread Peter Maydell
On 28 March 2014 14:22, Peter Maydell wrote: > Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get() > does not return zero-initialized memory. Spotted by the clang sanitizer > (which complained when the value loaded in dma_complete() was not valid > for a bool type); this migh

[Qemu-devel] [PATCH 1/2] dma-helpers: Initialize DMAAIOCB in_cancel flag

2014-03-28 Thread Peter Maydell
Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get() does not return zero-initialized memory. Spotted by the clang sanitizer (which complained when the value loaded in dma_complete() was not valid for a bool type); this might have resulted in leaking the AIO block. Signed-off-