Re: [Qemu-devel] [PATCH 1/2] cutils: remove one unnecessary pointer operation

2019-06-12 Thread Juan Quintela
Wei Yang wrote: > Since we will not operate on the next address pointed by out, it is not > necessary to do addition on it. > > After removing the operation, the function size reduced 16/18 bytes. > > Signed-off-by: Wei Yang Reviewed-by: Juan Quintela Included. I agree with David that the com

Re: [Qemu-devel] [PATCH 1/2] cutils: remove one unnecessary pointer operation

2019-06-11 Thread Wei Yang
On Tue, Jun 11, 2019 at 06:49:54PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> Since we will not operate on the next address pointed by out, it is not >> necessary to do addition on it. >> >> After removing the operation, the function size reduced 16/

Re: [Qemu-devel] [PATCH 1/2] cutils: remove one unnecessary pointer operation

2019-06-11 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > Since we will not operate on the next address pointed by out, it is not > necessary to do addition on it. > > After removing the operation, the function size reduced 16/18 bytes. For me with a -O3 it didn't make any difference - the compiler was

[Qemu-devel] [PATCH 1/2] cutils: remove one unnecessary pointer operation

2019-06-09 Thread Wei Yang
Since we will not operate on the next address pointed by out, it is not necessary to do addition on it. After removing the operation, the function size reduced 16/18 bytes. Signed-off-by: Wei Yang --- util/cutils.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util