Re: [Qemu-devel] [PATCH 1/2] coroutine-ucontext: Help valgrind understand coroutines

2012-07-13 Thread Kevin Wolf
Am 13.07.2012 10:45, schrieb Kevin Wolf: > Am 12.07.2012 19:07, schrieb Stefan Weil: >> Great that you address this issue! >> I have two annotations, please see below. >> >> >> Am 12.07.2012 16:27, schrieb Kevin Wolf: >>> valgrind tends to get confused and report false positives when you >>> switch

Re: [Qemu-devel] [PATCH 1/2] coroutine-ucontext: Help valgrind understand coroutines

2012-07-13 Thread Kevin Wolf
Am 12.07.2012 19:07, schrieb Stefan Weil: > Great that you address this issue! > I have two annotations, please see below. > > > Am 12.07.2012 16:27, schrieb Kevin Wolf: >> valgrind tends to get confused and report false positives when you >> switch stacks and don't tell it about it. >> >> Signed

Re: [Qemu-devel] [PATCH 1/2] coroutine-ucontext: Help valgrind understand coroutines

2012-07-13 Thread Kevin Wolf
Am 12.07.2012 19:14, schrieb Peter Maydell: > On 12 July 2012 15:27, Kevin Wolf wrote: >> valgrind tends to get confused and report false positives when you >> switch stacks and don't tell it about it. > > Does the sigaltstack backend need anything similar? Don't know, I never used valgrind with

Re: [Qemu-devel] [PATCH 1/2] coroutine-ucontext: Help valgrind understand coroutines

2012-07-12 Thread Peter Maydell
On 12 July 2012 15:27, Kevin Wolf wrote: > valgrind tends to get confused and report false positives when you > switch stacks and don't tell it about it. Does the sigaltstack backend need anything similar? -- PMM

Re: [Qemu-devel] [PATCH 1/2] coroutine-ucontext: Help valgrind understand coroutines

2012-07-12 Thread Stefan Weil
Great that you address this issue! I have two annotations, please see below. Am 12.07.2012 16:27, schrieb Kevin Wolf: valgrind tends to get confused and report false positives when you switch stacks and don't tell it about it. Signed-off-by: Kevin Wolf --- configure| 18 ++

[Qemu-devel] [PATCH 1/2] coroutine-ucontext: Help valgrind understand coroutines

2012-07-12 Thread Kevin Wolf
valgrind tends to get confused and report false positives when you switch stacks and don't tell it about it. Signed-off-by: Kevin Wolf --- configure| 18 ++ coroutine-ucontext.c | 21 + 2 files changed, 39 insertions(+), 0 deletions(-) diff --