On Fri, Jul 20, Peter Maydell wrote:
> I actually wrote a patch sitting on top of this one by Stefan
> which moves the flag to QEMU_CFLAGS;
> both are in the 11-patch series dealing with various configure
> Werror issues:
> http://patchwork.ozlabs.org/patch/171689/
The actual CFLAGS issue had to
On 20 July 2012 13:28, Andreas Färber wrote:
> Am 17.07.2012 21:19, schrieb Peter Maydell:
>> On 17 July 2012 20:07, Stefan Weil wrote:
>>> If the user overrides CFLAGS, I expect that he/she will notice
>>> that compilation fails and hopefully find the cause (only
>>> expert users should override
Am 17.07.2012 21:19, schrieb Peter Maydell:
> On 17 July 2012 20:07, Stefan Weil wrote:
>> If the user overrides CFLAGS, I expect that he/she will notice
>> that compilation fails and hopefully find the cause (only
>> expert users should override CFLAGS). Overriding -march=i486
>> might be useful
On 17 July 2012 20:07, Stefan Weil wrote:
> If the user overrides CFLAGS, I expect that he/she will notice
> that compilation fails and hopefully find the cause (only
> expert users should override CFLAGS). Overriding -march=i486
> might be useful to set -march=i686.
>
> Therefore it was not so ob
Am 17.07.2012 20:43, schrieb Peter Maydell:
On 15 July 2012 19:34, Stefan Weil wrote:
"+=" does not work with dash and other simple /bin/sh implementations.
The new code prepends the flag while the old code either did not work
(it continued after an error message which typically was not read)
On 15 July 2012 19:34, Stefan Weil wrote:
> "+=" does not work with dash and other simple /bin/sh implementations.
>
> The new code prepends the flag while the old code either did not work
> (it continued after an error message which typically was not read) or
> appended the flag. That difference
"+=" does not work with dash and other simple /bin/sh implementations.
The new code prepends the flag while the old code either did not work
(it continued after an error message which typically was not read) or
appended the flag. That difference should not matter here.
Signed-off-by: Stefan Weil
