On 09/02/2017 14:02, Gerd Hoffmann wrote:
> The blit_region_is_unsafe checks don't work correctly for the
> patterncopy source. It's a fixed-sized region, which doesn't
> depend on cirrus_blt_{width,height}. So go do the check in
> cirrus_bitblt_common_patterncopy instead, then tell blit_is_unsaf
Seems to work.
Took me a while to realize whether the else case was safe, but given the
patternfill functions' access patterns and CIRRUS_BLTBUFSIZE being 8k it
should be fine.
On Thu, Feb 09, 2017 at 02:02:20PM +0100, Gerd Hoffmann wrote:
> The blit_region_is_unsafe checks don't work correctly fo
* Gerd Hoffmann (kra...@redhat.com) wrote:
> The blit_region_is_unsafe checks don't work correctly for the
> patterncopy source. It's a fixed-sized region, which doesn't
> depend on cirrus_blt_{width,height}. So go do the check in
> cirrus_bitblt_common_patterncopy instead, then tell blit_is_unsa
The blit_region_is_unsafe checks don't work correctly for the
patterncopy source. It's a fixed-sized region, which doesn't
depend on cirrus_blt_{width,height}. So go do the check in
cirrus_bitblt_common_patterncopy instead, then tell blit_is_unsafe that
it doesn't need to verify the source. Also
