Re: [Qemu-devel] [PATCH 1/2] blockjob: assert(cb) in the entry functions of blockjob

2016-06-22 Thread Changlong Xie
On 06/23/2016 02:21 PM, Kevin Wolf wrote: Am 23.06.2016 um 03:04 hat Changlong Xie geschrieben: On 06/23/2016 01:31 AM, Eric Blake wrote: On 06/22/2016 04:19 AM, Paolo Bonzini wrote: On 22/06/2016 12:12, Changlong Xie wrote: commit/mirror/stream/backup use block_job_create(..., cb,..) to c

Re: [Qemu-devel] [PATCH 1/2] blockjob: assert(cb) in the entry functions of blockjob

2016-06-22 Thread Kevin Wolf
Am 23.06.2016 um 03:04 hat Changlong Xie geschrieben: > On 06/23/2016 01:31 AM, Eric Blake wrote: > >On 06/22/2016 04:19 AM, Paolo Bonzini wrote: > >> > >> > >>On 22/06/2016 12:12, Changlong Xie wrote: > >>> > >>>commit/mirror/stream/backup use block_job_create(..., cb,..) to create > >>>relevant b

Re: [Qemu-devel] [PATCH 1/2] blockjob: assert(cb) in the entry functions of blockjob

2016-06-22 Thread Changlong Xie
On 06/23/2016 01:31 AM, Eric Blake wrote: On 06/22/2016 04:19 AM, Paolo Bonzini wrote: On 22/06/2016 12:12, Changlong Xie wrote: commit/mirror/stream/backup use block_job_create(..., cb,..) to create relevant blockjob. When they finished, these jobs will invoke block_job_completed, then invo

Re: [Qemu-devel] [PATCH 1/2] blockjob: assert(cb) in the entry functions of blockjob

2016-06-22 Thread Eric Blake
On 06/22/2016 04:19 AM, Paolo Bonzini wrote: > > > On 22/06/2016 12:12, Changlong Xie wrote: >> >> commit/mirror/stream/backup use block_job_create(..., cb,..) to create >> relevant blockjob. When they finished, these jobs will invoke >> block_job_completed, then invoke job->cb() unconditionally.

Re: [Qemu-devel] [PATCH 1/2] blockjob: assert(cb) in the entry functions of blockjob

2016-06-22 Thread Paolo Bonzini
On 22/06/2016 12:12, Changlong Xie wrote: > > commit/mirror/stream/backup use block_job_create(..., cb,..) to create > relevant blockjob. When they finished, these jobs will invoke > block_job_completed, then invoke job->cb() unconditionally. So i think > we need this to avoid segment fault. Act

Re: [Qemu-devel] [PATCH 1/2] blockjob: assert(cb) in the entry functions of blockjob

2016-06-22 Thread Changlong Xie
On 06/22/2016 05:50 PM, Paolo Bonzini wrote: On 22/06/2016 11:16, Changlong Xie wrote: Signed-off-by: Changlong Xie --- block/commit.c | 1 + block/mirror.c | 2 ++ block/stream.c | 1 + 3 files changed, 4 insertions(+) Why is this useful? commit/mirror/stream/backup use block_job_c

Re: [Qemu-devel] [PATCH 1/2] blockjob: assert(cb) in the entry functions of blockjob

2016-06-22 Thread Paolo Bonzini
On 22/06/2016 11:16, Changlong Xie wrote: > Signed-off-by: Changlong Xie > --- > block/commit.c | 1 + > block/mirror.c | 2 ++ > block/stream.c | 1 + > 3 files changed, 4 insertions(+) Why is this useful? Paolo > diff --git a/block/commit.c b/block/commit.c > index 444333b..13b55c1 100644

[Qemu-devel] [PATCH 1/2] blockjob: assert(cb) in the entry functions of blockjob

2016-06-22 Thread Changlong Xie
Signed-off-by: Changlong Xie --- block/commit.c | 1 + block/mirror.c | 2 ++ block/stream.c | 1 + 3 files changed, 4 insertions(+) diff --git a/block/commit.c b/block/commit.c index 444333b..13b55c1 100644 --- a/block/commit.c +++ b/block/commit.c @@ -223,6 +223,7 @@ void commit_start(BlockDri