Re: [Qemu-devel] [PATCH 1/2] blockdev: Add dynamic generation of module_block.h

2016-06-16 Thread Colin Lord
On 06/16/2016 12:59 AM, Fam Zheng wrote: > On Wed, 06/15 14:40, Colin Lord wrote: >> From: Marc Mari >> >> To simplify the addition of new block modules, add a script that generates >> include/qemu/module_block.h automatically from the modules' source code. >> >> This script assumes that the QEMU

Re: [Qemu-devel] [PATCH 1/2] blockdev: Add dynamic generation of module_block.h

2016-06-15 Thread Fam Zheng
On Wed, 06/15 14:40, Colin Lord wrote: > From: Marc Mari > > To simplify the addition of new block modules, add a script that generates > include/qemu/module_block.h automatically from the modules' source code. > > This script assumes that the QEMU coding style rules are followed. > > Signed-of

Re: [Qemu-devel] [PATCH 1/2] blockdev: Add dynamic generation of module_block.h

2016-06-15 Thread Paolo Bonzini
On 15/06/2016 20:40, Colin Lord wrote: > +def add_module(fhader, library, format_name, protocol_name, fhader looks like a typo. Paolo > +probe, probe_device): > +lines = [] > +lines.append('.library_name = "' + library + '",') > +if format_name != "": > +lin

[Qemu-devel] [PATCH 1/2] blockdev: Add dynamic generation of module_block.h

2016-06-15 Thread Colin Lord
From: Marc Mari To simplify the addition of new block modules, add a script that generates include/qemu/module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc MarĂ­ Signed-off-by: Colin Lord --- .gitig