Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-28 Thread Dr. David Alan Gilbert
* Christian Borntraeger (borntrae...@de.ibm.com) wrote: > On 04/27/2017 03:47 PM, Andrea Arcangeli wrote: > > On Thu, Apr 27, 2017 at 08:44:03AM +0200, Christian Borntraeger wrote: > >> I have started instrumenting the kernel. I can see a set_pte_at for this > >> address > >> and I see an (to be u

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-28 Thread Christian Borntraeger
On 04/27/2017 03:47 PM, Andrea Arcangeli wrote: > On Thu, Apr 27, 2017 at 08:44:03AM +0200, Christian Borntraeger wrote: >> I have started instrumenting the kernel. I can see a set_pte_at for this >> address >> and I see an (to be understood) invalidation shortly after that which >> explains >> w

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-27 Thread Andrea Arcangeli
On Thu, Apr 27, 2017 at 08:44:03AM +0200, Christian Borntraeger wrote: > I have started instrumenting the kernel. I can see a set_pte_at for this > address > and I see an (to be understood) invalidation shortly after that which explains > why I get a fault. Sounds great that you can see an invali

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-27 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > When an all-zero page is received during the precopy > > phase of a postcopy-enabled migration we must force > > allocation otherwise accesses to the page will still > >

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-26 Thread Christian Borntraeger
On 04/27/2017 05:20 AM, Peter Xu wrote: > On Wed, Apr 26, 2017 at 09:37:43PM +0200, Andrea Arcangeli wrote: >> Hello, >> >> On Wed, Apr 26, 2017 at 08:04:43PM +0100, Dr. David Alan Gilbert wrote: >>> * Christian Borntraeger (borntrae...@de.ibm.com) wrote: On 04/26/2017 08:37 PM, Dr. David Alan

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-26 Thread Peter Xu
On Wed, Apr 26, 2017 at 09:37:43PM +0200, Andrea Arcangeli wrote: > Hello, > > On Wed, Apr 26, 2017 at 08:04:43PM +0100, Dr. David Alan Gilbert wrote: > > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: > > > On 04/26/2017 08:37 PM, Dr. David Alan Gilbert (git) wrote: > > > > From: "Dr. Da

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-26 Thread Christian Borntraeger
On 04/26/2017 09:52 PM, Christian Borntraeger wrote: > On 04/26/2017 09:04 PM, Dr. David Alan Gilbert wrote: >> * Christian Borntraeger (borntrae...@de.ibm.com) wrote: >>> On 04/26/2017 08:37 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" When an all-zero pag

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-26 Thread Christian Borntraeger
On 04/26/2017 09:04 PM, Dr. David Alan Gilbert wrote: > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: >> On 04/26/2017 08:37 PM, Dr. David Alan Gilbert (git) wrote: >>> From: "Dr. David Alan Gilbert" >>> >>> When an all-zero page is received during the precopy >>> phase of a postcopy-ena

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-26 Thread Andrea Arcangeli
Hello, On Wed, Apr 26, 2017 at 08:04:43PM +0100, Dr. David Alan Gilbert wrote: > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: > > On 04/26/2017 08:37 PM, Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > When an all-zero page is received during the p

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-26 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > When an all-zero page is received during the precopy > phase of a postcopy-enabled migration we must force > allocation otherwise accesses to the page will still > get blocked by userfault. > > Symptom: > a) If the page

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-26 Thread Dr. David Alan Gilbert
* Christian Borntraeger (borntrae...@de.ibm.com) wrote: > On 04/26/2017 08:37 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > When an all-zero page is received during the precopy > > phase of a postcopy-enabled migration we must force > > allocation otherwise ac

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-26 Thread Christian Borntraeger
On 04/26/2017 08:37 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When an all-zero page is received during the precopy > phase of a postcopy-enabled migration we must force > allocation otherwise accesses to the page will still > get blocked by userfault. > > Sympt

[Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-26 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" When an all-zero page is received during the precopy phase of a postcopy-enabled migration we must force allocation otherwise accesses to the page will still get blocked by userfault. Symptom: a) If the page is accessed by a device during device-load then we