Re: [Qemu-devel] [PATCH 1/2] PPC: Add dump_mmu() for 6xx

2013-06-20 Thread Fabien Chouteau
On 06/20/2013 01:16 PM, Alexander Graf wrote: > > On 18.06.2013, at 18:04, Fabien Chouteau wrote: > >> On 06/18/2013 05:31 PM, Alexander Graf wrote: +for (type = 0; type < 2; type++) >>> >>> You need braces on these. Please run your patch through checkpatch.pl :). >> >> I did ;) >> >> ->

Re: [Qemu-devel] [PATCH 1/2] PPC: Add dump_mmu() for 6xx

2013-06-20 Thread Alexander Graf
On 18.06.2013, at 18:04, Fabien Chouteau wrote: > On 06/18/2013 05:31 PM, Alexander Graf wrote: >>> +for (type = 0; type < 2; type++) >> >> You need braces on these. Please run your patch through checkpatch.pl :). > > I did ;) > > -> ./scripts/checkpatch.pl 0001-PPC-Add-dump_mmu-for-6xx.pa

Re: [Qemu-devel] [PATCH 1/2] PPC: Add dump_mmu() for 6xx

2013-06-18 Thread Fabien Chouteau
On 06/18/2013 05:31 PM, Alexander Graf wrote: >> +for (type = 0; type < 2; type++) > > You need braces on these. Please run your patch through checkpatch.pl :). I did ;) -> ./scripts/checkpatch.pl 0001-PPC-Add-dump_mmu-for-6xx.patch total: 0 errors, 0 warnings, 51 lines checked 0001-PPC-Add

Re: [Qemu-devel] [PATCH 1/2] PPC: Add dump_mmu() for 6xx

2013-06-18 Thread Alexander Graf
On 18.06.2013, at 16:53, Fabien Chouteau wrote: > "(qemu) info tlb" is a very useful tool for debugging, so I implemented > the missing 6xx version. > > Signed-off-by: Fabien Chouteau > --- > target-ppc/mmu_helper.c | 39 +++ > 1 file changed, 39 insertions(

[Qemu-devel] [PATCH 1/2] PPC: Add dump_mmu() for 6xx

2013-06-18 Thread Fabien Chouteau
"(qemu) info tlb" is a very useful tool for debugging, so I implemented the missing 6xx version. Signed-off-by: Fabien Chouteau --- target-ppc/mmu_helper.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/target-ppc/mmu_helper.c b/target-ppc/mmu_help