Re: [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

2012-05-23 Thread Peter Maydell
On 23 May 2012 15:41, Andreas Färber wrote: > Am 23.05.2012 14:44, schrieb Peter Maydell: >> On 20 May 2012 10:02, Gleb Natapov wrote: >>> There can be only one fw_cfg device, so saving global reference to it >>> removes the need to pass its pointer around. >> >> This seems like a backwards step

Re: [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

2012-05-23 Thread Andreas Färber
Am 23.05.2012 14:44, schrieb Peter Maydell: > On 20 May 2012 10:02, Gleb Natapov wrote: >> There can be only one fw_cfg device, so saving global reference to it >> removes the need to pass its pointer around. > > This seems like a backwards step to me: one of the things that prevents > us support

Re: [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

2012-05-23 Thread Anthony Liguori
On 05/23/2012 08:32 AM, Gleb Natapov wrote: On Wed, May 23, 2012 at 08:25:35AM -0500, Anthony Liguori wrote: On 05/23/2012 07:37 AM, Gleb Natapov wrote: Ping. I don't understand why you're pinging.. The patch has just been on the list for a couple of days and is definitely not a 1.1 candidat

Re: [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

2012-05-23 Thread Gleb Natapov
On Wed, May 23, 2012 at 08:25:35AM -0500, Anthony Liguori wrote: > On 05/23/2012 07:37 AM, Gleb Natapov wrote: > >Ping. > > I don't understand why you're pinging.. The patch has just been on > the list for a couple of days and is definitely not a 1.1 candidate. > Am I missing something? > It is

Re: [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

2012-05-23 Thread Anthony Liguori
On 05/23/2012 07:37 AM, Gleb Natapov wrote: Ping. I don't understand why you're pinging.. The patch has just been on the list for a couple of days and is definitely not a 1.1 candidate. Am I missing something? However... On Sun, May 20, 2012 at 12:02:40PM +0300, Gleb Natapov wrote: The

Re: [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

2012-05-23 Thread Gleb Natapov
On Wed, May 23, 2012 at 01:44:45PM +0100, Peter Maydell wrote: > On 20 May 2012 10:02, Gleb Natapov wrote: > > There can be only one fw_cfg device, so saving global reference to it > > removes the need to pass its pointer around. > > This seems like a backwards step to me: one of the things that

Re: [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

2012-05-23 Thread Peter Maydell
On 20 May 2012 10:02, Gleb Natapov wrote: > There can be only one fw_cfg device, so saving global reference to it > removes the need to pass its pointer around. This seems like a backwards step to me: one of the things that prevents us supporting "two separate machines in one emulation" is that w

Re: [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

2012-05-23 Thread Gleb Natapov
Ping. On Sun, May 20, 2012 at 12:02:40PM +0300, Gleb Natapov wrote: > There can be only one fw_cfg device, so saving global reference to it > removes the need to pass its pointer around. > > Signed-off-by: Gleb Natapov > --- > hw/fw_cfg.c | 110 > +++-

[Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

2012-05-20 Thread Gleb Natapov
There can be only one fw_cfg device, so saving global reference to it removes the need to pass its pointer around. Signed-off-by: Gleb Natapov --- hw/fw_cfg.c | 110 +++-- hw/fw_cfg.h | 15 +++ hw/loader.c | 10 + hw/

Re: [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

2012-05-14 Thread Blue Swirl
On Mon, May 14, 2012 at 12:34 PM, Gleb Natapov wrote: > There can be only one fw_cfg device, so saving global reference to it > removes the need to pass its pointer around. >From OO point of view this is not so great, but ... > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.c       |  106 >

[Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

2012-05-14 Thread Gleb Natapov
There can be only one fw_cfg device, so saving global reference to it removes the need to pass its pointer around. Signed-off-by: Gleb Natapov --- hw/fw_cfg.c | 106 ++--- hw/fw_cfg.h | 15 +++ hw/loader.c | 10 + hw/