Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace

2011-08-29 Thread Michael Roth
On 08/29/2011 07:28 AM, Stefan Hajnoczi wrote: On Sun, Aug 28, 2011 at 10:08 PM, Blue Swirl wrote: On Sun, Aug 28, 2011 at 6:13 PM, Lluís wrote: Blue Swirl writes: On Sat, Aug 27, 2011 at 5:56 PM, Lluís wrote: I sent a patch that should fix it for everybody linking with the tracing object

Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace

2011-08-29 Thread Lluís
Blue Swirl writes: >>> Using the sort function looks hackish to me. Maybe the linkage should >>> be controlled by configure instead? >> >> What do you mean? Moving the logic for selecting the object files to >> link with on each top-level target out into the configure? > Add CONFIG_QEMU_TIMER, c

Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace

2011-08-29 Thread Stefan Hajnoczi
On Sun, Aug 28, 2011 at 10:08 PM, Blue Swirl wrote: > On Sun, Aug 28, 2011 at 6:13 PM, Lluís wrote: >> Blue Swirl writes: >> >>> On Sat, Aug 27, 2011 at 5:56 PM, Lluís wrote: >> I sent a patch that should fix it for everybody linking with the tracing >> objects: >> >> http://list

Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace

2011-08-28 Thread Blue Swirl
On Sun, Aug 28, 2011 at 6:13 PM, Lluís wrote: > Blue Swirl writes: > >> On Sat, Aug 27, 2011 at 5:56 PM, Lluís wrote: > I sent a patch that should fix it for everybody linking with the tracing > objects: > > http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03150.html >>> >>

Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace

2011-08-28 Thread Lluís
Blue Swirl writes: > On Sat, Aug 27, 2011 at 5:56 PM, Lluís wrote: I sent a patch that should fix it for everybody linking with the tracing objects: http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03150.html >> >>> With your patch, there are warnings from linker: >>>

Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace

2011-08-28 Thread Blue Swirl
On Sat, Aug 27, 2011 at 5:56 PM, Lluís wrote: > Blue Swirl writes: > >> On Fri, Aug 26, 2011 at 7:12 PM, Lluís wrote: >>> Blue Swirl writes: >>> 957f1f99f263d57612807a9535f75ca4473f05f0 didn't consider that qemu-timer-common.o is needed by simpletrace. >>> Fix by adding it to qga o

Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace

2011-08-27 Thread Lluís
Blue Swirl writes: > On Fri, Aug 26, 2011 at 7:12 PM, Lluís wrote: >> Blue Swirl writes: >> >>> 957f1f99f263d57612807a9535f75ca4473f05f0 didn't consider >>> that qemu-timer-common.o is needed by simpletrace. >> >>> Fix by adding it to qga object list. >> >>> Signed-off-by: Blue Swirl >>> ---

Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace

2011-08-27 Thread Blue Swirl
On Fri, Aug 26, 2011 at 7:12 PM, Lluís wrote: > Blue Swirl writes: > >> 957f1f99f263d57612807a9535f75ca4473f05f0 didn't consider >> that qemu-timer-common.o is needed by simpletrace. > >> Fix by adding it to qga object list. > >> Signed-off-by: Blue Swirl >> --- >>  Makefile.objs |    3 +++ >>  1

Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace

2011-08-26 Thread Lluís
Blue Swirl writes: > 957f1f99f263d57612807a9535f75ca4473f05f0 didn't consider > that qemu-timer-common.o is needed by simpletrace. > Fix by adding it to qga object list. > Signed-off-by: Blue Swirl > --- > Makefile.objs |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > diff --g

[Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace

2011-08-26 Thread Blue Swirl
957f1f99f263d57612807a9535f75ca4473f05f0 didn't consider that qemu-timer-common.o is needed by simpletrace. Fix by adding it to qga object list. Signed-off-by: Blue Swirl --- Makefile.objs |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/Makefile.objs b/Makefile.objs i