Re: [Qemu-devel] [PATCH 1/2] Emulated CCID card: QOMify

2016-02-02 Thread Cao jin
On 02/02/2016 04:30 PM, Michael Tokarev wrote: 02.02.2016 11:25, Cao jin wrote: On 02/02/2016 04:15 PM, Michael Tokarev wrote: Why did you move the type definition from .c to .h file? It is only referenced in .c, no? [] Yes, that type definition is referred only in .c for now, but we are no

Re: [Qemu-devel] [PATCH 1/2] Emulated CCID card: QOMify

2016-02-02 Thread Michael Tokarev
02.02.2016 11:25, Cao jin wrote: > On 02/02/2016 04:15 PM, Michael Tokarev wrote: >> Why did you move the type definition from .c to .h file? >> It is only referenced in .c, no? [] > Yes, that type definition is referred only in .c for now, but we are not sure > about it in the future, for better

Re: [Qemu-devel] [PATCH 1/2] Emulated CCID card: QOMify

2016-02-02 Thread Cao jin
On 02/02/2016 04:15 PM, Michael Tokarev wrote: 01.02.2016 09:53, Cao jin wrote: Signed-off-by: Cao jin --- hw/usb/ccid-card-emulated.c | 20 +--- hw/usb/ccid.h | 4 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/hw/usb/ccid-card-emulat

Re: [Qemu-devel] [PATCH 1/2] Emulated CCID card: QOMify

2016-02-02 Thread Michael Tokarev
01.02.2016 09:53, Cao jin wrote: > Signed-off-by: Cao jin > --- > hw/usb/ccid-card-emulated.c | 20 +--- > hw/usb/ccid.h | 4 > 2 files changed, 13 insertions(+), 11 deletions(-) > > diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c > inde

[Qemu-devel] [PATCH 1/2] Emulated CCID card: QOMify

2016-01-31 Thread Cao jin
Signed-off-by: Cao jin --- hw/usb/ccid-card-emulated.c | 20 +--- hw/usb/ccid.h | 4 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c index 869a63c..0b05260 100644 --- a/hw/usb/ccid-card-