Re: [Qemu-devel] [PATCH 1/2] Allow 1366x768 as a valid VGA resolution

2011-11-03 Thread John Baboval
This is a good idea. I'm going to re-work the patch, but I have a lot of other stuff going on too, so it may be a week or so before I get back to it. On 11/01/2011 12:57 PM, Gerd Hoffmann wrote: On 11/01/11 14:39, John Baboval wrote: I don't know of any reason for it. I'd guess it is alignmen

Re: [Qemu-devel] [PATCH 1/2] Allow 1366x768 as a valid VGA resolution

2011-11-01 Thread Gerd Hoffmann
On 11/01/11 14:39, John Baboval wrote: > I don't know of any reason for it. I'd guess it is alignment, probably not important for all color depts. Maybe it is a good idea to do all sanity checks in the VBE_DISPI_INDEX_ENABLE branch where the actual mode switch happens. Then you already know xres

Re: [Qemu-devel] [PATCH 1/2] Allow 1366x768 as a valid VGA resolution

2011-11-01 Thread John Baboval
I don't know of any reason for it. -John On Nov 1, 2011, at 4:58 AM, "Gerd Hoffmann" wrote: > On 10/28/11 21:24, John Baboval wrote: >> 760p TV panels have a 1366x768 resolution, and have been popular >> recently as low-cost monitors. The 1366 resolution doesn't pass >> the (xres & 7) == 0 te

Re: [Qemu-devel] [PATCH 1/2] Allow 1366x768 as a valid VGA resolution

2011-11-01 Thread Gerd Hoffmann
On 10/28/11 21:24, John Baboval wrote: > 760p TV panels have a 1366x768 resolution, and have been popular > recently as low-cost monitors. The 1366 resolution doesn't pass > the (xres & 7) == 0 test. Why is it save to simply remove the test? Guess there is a reason why it is there in the first pla

[Qemu-devel] [PATCH 1/2] Allow 1366x768 as a valid VGA resolution

2011-10-28 Thread John Baboval
760p TV panels have a 1366x768 resolution, and have been popular recently as low-cost monitors. The 1366 resolution doesn't pass the (xres & 7) == 0 test. Signed-off-by: John V. Baboval --- hw/vga.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/vga.c b/hw/vga.c in