Re: [Qemu-devel] [PATCH 1/2] Add param Error** to msi_init() & modify the callers

2015-12-09 Thread Cao jin
On 12/08/2015 11:01 PM, Markus Armbruster wrote: Cao jin writes: Hi Markus, I have to say, you really did a amazing review for this "trivial "patch, thanks a lot & really appreciate it:) Thanks! I'm afraid the problem you picked isn't trivial, but I hope it's still simple enough to b

Re: [Qemu-devel] [PATCH 1/2] Add param Error** to msi_init() & modify the callers

2015-12-08 Thread Markus Armbruster
Cao jin writes: > Hi Markus, > I have to say, you really did a amazing review for this "trivial > "patch, thanks a lot & really appreciate it:) Thanks! I'm afraid the problem you picked isn't trivial, but I hope it's still simple enough to be a useful exercise to get you going with the code

Re: [Qemu-devel] [PATCH 1/2] Add param Error** to msi_init() & modify the callers

2015-12-08 Thread Cao jin
Hi Markus, I have to say, you really did a amazing review for this "trivial "patch, thanks a lot & really appreciate it:) On 12/07/2015 05:59 PM, Markus Armbruster wrote: Cao jin writes: msi_init() is a supporting function in PCI device initialization, in order to convert .init() to .re

Re: [Qemu-devel] [PATCH 1/2] Add param Error** to msi_init() & modify the callers

2015-12-07 Thread Markus Armbruster
Cao jin writes: > msi_init() is a supporting function in PCI device initialization, in order to > convert .init() to .realize(), it should be modified first. Also modify the > callers > > Bonus: add more comment for msi_init(). Incomplete. See notes on impact inline. > Signed-off-by: Cao jin

[Qemu-devel] [PATCH 1/2] Add param Error** to msi_init() & modify the callers

2015-12-07 Thread Cao jin
msi_init() is a supporting function in PCI device initialization, in order to convert .init() to .realize(), it should be modified first. Also modify the callers Bonus: add more comment for msi_init(). Signed-off-by: Cao jin --- hw/audio/intel-hda.c | 7 ++- hw/ide/ich.c