Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-04 Thread Jean-Christophe DUBOIS
On 05/04/2013 10:29 AM, Peter Maydell wrote: On 4 May 2013 09:27, Andreas Färber wrote: Am 04.05.2013 10:22, schrieb Jean-Christophe DUBOIS: Do you mean arm_load_kernel() should test for qtest_enable() or should I call arm_load_kernel() only if !qtest_enable() (there is not much platform check

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-04 Thread Peter Maydell
On 4 May 2013 09:27, Andreas Färber wrote: > Am 04.05.2013 10:22, schrieb Jean-Christophe DUBOIS: >> Do you mean arm_load_kernel() should test for qtest_enable() or should I >> call arm_load_kernel() only if !qtest_enable() (there is not much >> platform checking for qtest_enable() at this time an

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-04 Thread Andreas Färber
Am 04.05.2013 10:22, schrieb Jean-Christophe DUBOIS: > On 05/03/2013 06:41 PM, Andreas Färber wrote: >>CCtests/libi2c-imx.o >>LINK tests/tmp105-test >>CCtests/ds1338-test.o >>LINK tests/ds1338-test >> GTESTER check-qtest-arm >> Kernel image must be specified >> Without see

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-04 Thread Jean-Christophe DUBOIS
On 05/03/2013 06:41 PM, Andreas Färber wrote: CCtests/libi2c-imx.o LINK tests/tmp105-test CCtests/ds1338-test.o LINK tests/ds1338-test GTESTER check-qtest-arm Kernel image must be specified Without seeing your code and since tmp105-test is working on my side, I can only gues

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Andreas Färber
Am 03.05.2013 18:04, schrieb Jean-Christophe DUBOIS: > So I added a libi2c-imx.c file, a ds1338-test.c file ... (Note that in light of http://patchwork.ozlabs.org/patch/241004/ this will likely become libqos/i2c-imx.c.) > but when I run "make check" I get the following. [...] > $ make check [...]

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Jean-Christophe DUBOIS
On 05/03/2013 05:20 PM, Andreas Färber wrote: Am 03.05.2013 17:16, schrieb Jean-Christophe DUBOIS: Andreas, On 05/02/2013 02:38 PM, Andreas Färber wrote: Hi, Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS: Signed-off-by: Jean-Christophe DUBOIS --- default-configs/arm-softmmu.mak |

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Andreas Färber
Am 03.05.2013 17:16, schrieb Jean-Christophe DUBOIS: > Andreas, > > On 05/02/2013 02:38 PM, Andreas Färber wrote: >> Hi, >> >> Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS: >>> Signed-off-by: Jean-Christophe DUBOIS >>> --- >>> default-configs/arm-softmmu.mak | 2 + >>> hw/i2c/Makefile

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Jean-Christophe DUBOIS
Andreas, On 05/02/2013 02:38 PM, Andreas Färber wrote: Hi, Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS: Signed-off-by: Jean-Christophe DUBOIS --- default-configs/arm-softmmu.mak | 2 + hw/i2c/Makefile.objs| 1 + hw/i2c/imx_i2c.c| 374 +++

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Andreas Färber
Am 02.05.2013 20:33, schrieb Jean-Christophe DUBOIS: > On 05/02/2013 02:16 PM, Peter Crosthwaite wrote: >> On Thu, May 2, 2013 at 5:53 AM, Jean-Christophe DUBOIS >> wrote: >>> +static int imx_i2c_init(SysBusDevice *dev) >>> +{ >> Use of the SysBusDeviceClass::init function is deprecated. Please us

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-02 Thread Peter Crosthwaite
Hi JC, On Fri, May 3, 2013 at 4:33 AM, Jean-Christophe DUBOIS wrote: > Peter, > > Thanks for you review. > > I have a few questions below. > > JC > > > On 05/02/2013 02:16 PM, Peter Crosthwaite wrote: >> >> Hi Jean-Christophe, >> >> Thanks for your contribution. Please run the patch through >> sc

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-02 Thread Jean-Christophe DUBOIS
Peter, Thanks for you review. I have a few questions below. JC On 05/02/2013 02:16 PM, Peter Crosthwaite wrote: Hi Jean-Christophe, Thanks for your contribution. Please run the patch through scripts/checkpatch.pl to check for formatting errors. On Thu, May 2, 2013 at 5:53 AM, Jean-Christoph

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-02 Thread Andreas Färber
Hi, Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS: > Signed-off-by: Jean-Christophe DUBOIS > --- > default-configs/arm-softmmu.mak | 2 + > hw/i2c/Makefile.objs| 1 + > hw/i2c/imx_i2c.c| 374 > > 3 files changed, 377

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-02 Thread Peter Crosthwaite
Hi Jean-Christophe, Thanks for your contribution. Please run the patch through scripts/checkpatch.pl to check for formatting errors. On Thu, May 2, 2013 at 5:53 AM, Jean-Christophe DUBOIS wrote: > Signed-off-by: Jean-Christophe DUBOIS > --- > default-configs/arm-softmmu.mak | 2 + > hw/i2c/M

[Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-01 Thread Jean-Christophe DUBOIS
Signed-off-by: Jean-Christophe DUBOIS --- default-configs/arm-softmmu.mak | 2 + hw/i2c/Makefile.objs| 1 + hw/i2c/imx_i2c.c| 374 3 files changed, 377 insertions(+) create mode 100644 hw/i2c/imx_i2c.c diff --git a/default