Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-22 Thread Amit Shah
On (Mon) 21 May 2012 [15:34:59], Anthony Liguori wrote: > On 05/21/2012 02:39 PM, Amit Shah wrote: > >On (Wed) 16 May 2012 [13:23:11], Anthony Liguori wrote: > >>On 05/16/2012 12:21 PM, Amit Shah wrote: > >>>On (Wed) 16 May 2012 [08:24:22], Anthony Liguori wrote: > On 05/16/2012 06:30 AM, Amit

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-21 Thread Anthony Liguori
On 05/21/2012 02:39 PM, Amit Shah wrote: On (Wed) 16 May 2012 [13:23:11], Anthony Liguori wrote: On 05/16/2012 12:21 PM, Amit Shah wrote: On (Wed) 16 May 2012 [08:24:22], Anthony Liguori wrote: On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-21 Thread Amit Shah
On (Wed) 16 May 2012 [13:23:11], Anthony Liguori wrote: > On 05/16/2012 12:21 PM, Amit Shah wrote: > >On (Wed) 16 May 2012 [08:24:22], Anthony Liguori wrote: > >>On 05/16/2012 06:30 AM, Amit Shah wrote: > >>>The Linux kernel already has a virtio-rng driver, this is the device > >>>implementation. >

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-21 Thread Amit Shah
On (Wed) 16 May 2012 [13:24:10], Anthony Liguori wrote: > On 05/16/2012 12:26 PM, Amit Shah wrote: > >On (Wed) 16 May 2012 [14:45:34], Daniel P. Berrange wrote: > >>On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: > >>>On 05/16/2012 06:30 AM, Amit Shah wrote: > The Linux kernel

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-21 Thread Amit Shah
On (Wed) 16 May 2012 [08:48:20], Anthony Liguori wrote: > On 05/16/2012 08:45 AM, Daniel P. Berrange wrote: > >On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: > >>On 05/16/2012 06:30 AM, Amit Shah wrote: > >>>The Linux kernel already has a virtio-rng driver, this is the device > >>

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Anthony Liguori
On 05/16/2012 12:26 PM, Amit Shah wrote: On (Wed) 16 May 2012 [14:45:34], Daniel P. Berrange wrote: On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. Wh

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Anthony Liguori
On 05/16/2012 12:21 PM, Amit Shah wrote: On (Wed) 16 May 2012 [08:24:22], Anthony Liguori wrote: On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When Linux needs more entropy, it puts a buffer in the vq. We then put

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Amit Shah
On (Wed) 16 May 2012 [08:24:22], Anthony Liguori wrote: > On 05/16/2012 06:30 AM, Amit Shah wrote: > >The Linux kernel already has a virtio-rng driver, this is the device > >implementation. > > > >When Linux needs more entropy, it puts a buffer in the vq. We then put > >entropy into that buffer, a

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Amit Shah
On (Wed) 16 May 2012 [09:02:03], Anthony Liguori wrote: > On 05/16/2012 08:53 AM, Daniel P. Berrange wrote: > >On Wed, May 16, 2012 at 08:48:20AM -0500, Anthony Liguori wrote: > >>On 05/16/2012 08:45 AM, Daniel P. Berrange wrote: > >>>On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote:

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Amit Shah
On (Wed) 16 May 2012 [14:45:34], Daniel P. Berrange wrote: > On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: > > On 05/16/2012 06:30 AM, Amit Shah wrote: > > >The Linux kernel already has a virtio-rng driver, this is the device > > >implementation. > > > > > >When Linux needs more

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Anthony Liguori
On 05/16/2012 08:53 AM, Daniel P. Berrange wrote: On Wed, May 16, 2012 at 08:48:20AM -0500, Anthony Liguori wrote: On 05/16/2012 08:45 AM, Daniel P. Berrange wrote: On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel alrea

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Daniel P. Berrange
On Wed, May 16, 2012 at 08:48:20AM -0500, Anthony Liguori wrote: > On 05/16/2012 08:45 AM, Daniel P. Berrange wrote: > >On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: > >>On 05/16/2012 06:30 AM, Amit Shah wrote: > >>>The Linux kernel already has a virtio-rng driver, this is the de

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Anthony Liguori
On 05/16/2012 08:45 AM, Daniel P. Berrange wrote: On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When Linux needs more entropy, it puts a buffer in th

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Daniel P. Berrange
On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: > On 05/16/2012 06:30 AM, Amit Shah wrote: > >The Linux kernel already has a virtio-rng driver, this is the device > >implementation. > > > >When Linux needs more entropy, it puts a buffer in the vq. We then put > >entropy into that

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Anthony Liguori
On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When Linux needs more entropy, it puts a buffer in the vq. We then put entropy into that buffer, and push it back to the guest. Feeding randomness from host's /dev/uran

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Amit Shah
On (Wed) 16 May 2012 [13:38:06], Paolo Bonzini wrote: > Il 16/05/2012 13:30, Amit Shah ha scritto: > > hw-obj-$(CONFIG_VIRTIO) += virtio-console.o > > +hw-obj-$(CONFIG_VIRTIO) += virtio-rng.o > > This needs to be conditional on CONFIG_LINUX too. Right. Thanks, Amit

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Paolo Bonzini
Il 16/05/2012 13:30, Amit Shah ha scritto: > hw-obj-$(CONFIG_VIRTIO) += virtio-console.o > +hw-obj-$(CONFIG_VIRTIO) += virtio-rng.o This needs to be conditional on CONFIG_LINUX too. Paolo

[Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Amit Shah
The Linux kernel already has a virtio-rng driver, this is the device implementation. When Linux needs more entropy, it puts a buffer in the vq. We then put entropy into that buffer, and push it back to the guest. Feeding randomness from host's /dev/urandom into the guest is sufficient, so this i