Re: [Qemu-devel] [PATCH 1/1] target-ppc: Fix booke206 tlbwe TLB instruction

2017-12-15 Thread David Gibson
On Tue, Nov 14, 2017 at 05:28:48PM +0100, Luc Michel wrote: > On 11/06/2017 07:16 AM, David Gibson wrote: > > On Thu, Nov 02, 2017 at 11:35:59AM +0100, Luc MICHEL wrote: > >> When overwritting a valid TLB entry with a new one, the previous page > >> were not flushed in QEMU TLB, leading to incohere

Re: [Qemu-devel] [PATCH 1/1] target-ppc: Fix booke206 tlbwe TLB instruction

2017-11-14 Thread Luc Michel
On 11/06/2017 07:16 AM, David Gibson wrote: > On Thu, Nov 02, 2017 at 11:35:59AM +0100, Luc MICHEL wrote: >> When overwritting a valid TLB entry with a new one, the previous page >> were not flushed in QEMU TLB, leading to incoherent mapping. This commit >> fixes this. > > I don't think this is ri

Re: [Qemu-devel] [PATCH 1/1] target-ppc: Fix booke206 tlbwe TLB instruction

2017-11-05 Thread David Gibson
On Thu, Nov 02, 2017 at 11:35:59AM +0100, Luc MICHEL wrote: > When overwritting a valid TLB entry with a new one, the previous page > were not flushed in QEMU TLB, leading to incoherent mapping. This commit > fixes this. I don't think this is right. As a rule, overwriting a TLB entry doesn't nece

[Qemu-devel] [PATCH 1/1] target-ppc: Fix booke206 tlbwe TLB instruction

2017-11-02 Thread Luc MICHEL
When overwritting a valid TLB entry with a new one, the previous page were not flushed in QEMU TLB, leading to incoherent mapping. This commit fixes this. Signed-off-by: Luc MICHEL --- target/ppc/mmu_helper.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --