Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate

2017-03-29 Thread Denis V. Lunev
On 03/29/2017 05:11 PM, Kevin Wolf wrote: > Am 29.03.2017 um 15:53 hat Denis V. Lunev geschrieben: >> On 03/29/2017 01:41 PM, Kevin Wolf wrote: >>> Am 28.03.2017 um 19:12 hat Denis V. Lunev geschrieben: On 03/28/2017 07:26 PM, Kevin Wolf wrote: > [ Cc: qemu-block ] > > Am 27.03.201

Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate

2017-03-29 Thread Kevin Wolf
Am 29.03.2017 um 16:18 hat Denis V. Lunev geschrieben: > On 03/29/2017 05:11 PM, Kevin Wolf wrote: > > Am 29.03.2017 um 15:53 hat Denis V. Lunev geschrieben: > >> On 03/29/2017 01:41 PM, Kevin Wolf wrote: > >>> The question is what the contract of bdrv_truncate() is. I think "you > >>> can only cal

Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate

2017-03-29 Thread Denis V. Lunev
On 03/29/2017 01:41 PM, Kevin Wolf wrote: > Am 28.03.2017 um 19:12 hat Denis V. Lunev geschrieben: >> On 03/28/2017 07:26 PM, Kevin Wolf wrote: >>> [ Cc: qemu-block ] >>> >>> Am 27.03.2017 um 16:38 hat Denis V. Lunev geschrieben: Parallels driver should not call bdrv_truncate if the image was

Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate

2017-03-29 Thread Kevin Wolf
Am 29.03.2017 um 15:53 hat Denis V. Lunev geschrieben: > On 03/29/2017 01:41 PM, Kevin Wolf wrote: > > Am 28.03.2017 um 19:12 hat Denis V. Lunev geschrieben: > >> On 03/28/2017 07:26 PM, Kevin Wolf wrote: > >>> [ Cc: qemu-block ] > >>> > >>> Am 27.03.2017 um 16:38 hat Denis V. Lunev geschrieben: >

Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate

2017-03-29 Thread Kevin Wolf
Am 28.03.2017 um 19:12 hat Denis V. Lunev geschrieben: > On 03/28/2017 07:26 PM, Kevin Wolf wrote: > > [ Cc: qemu-block ] > > > > Am 27.03.2017 um 16:38 hat Denis V. Lunev geschrieben: > >> Parallels driver should not call bdrv_truncate if the image was opened > >> in the read-only mode. Without th

Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate

2017-03-28 Thread Denis V. Lunev
On 03/28/2017 07:26 PM, Kevin Wolf wrote: > [ Cc: qemu-block ] > > Am 27.03.2017 um 16:38 hat Denis V. Lunev geschrieben: >> Parallels driver should not call bdrv_truncate if the image was opened >> in the read-only mode. Without the patch >> qemu-img check harddisk.hds >> asserts with >> b

Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate

2017-03-28 Thread Kevin Wolf
[ Cc: qemu-block ] Am 27.03.2017 um 16:38 hat Denis V. Lunev geschrieben: > Parallels driver should not call bdrv_truncate if the image was opened > in the read-only mode. Without the patch > qemu-img check harddisk.hds > asserts with > bdrv_truncate: Assertion `child->perm & BLK_PERM_RESI

Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate

2017-03-28 Thread Stefan Hajnoczi
On Mon, Mar 27, 2017 at 05:38:08PM +0300, Denis V. Lunev wrote: > Parallels driver should not call bdrv_truncate if the image was opened > in the read-only mode. Without the patch > qemu-img check harddisk.hds > asserts with > bdrv_truncate: Assertion `child->perm & BLK_PERM_RESIZE' failed.

[Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate

2017-03-27 Thread Denis V. Lunev
Parallels driver should not call bdrv_truncate if the image was opened in the read-only mode. Without the patch qemu-img check harddisk.hds asserts with bdrv_truncate: Assertion `child->perm & BLK_PERM_RESIZE' failed. Parameters used on the write path are not needed if the image is opened