Re: [Qemu-devel] [PATCH 1/1] io: ignore case in WebSocket HTTP header #PSBM-57554

2017-02-27 Thread Denis V. Lunev
On 02/27/2017 11:11 PM, Daniel P. Berrange wrote: > On Mon, Jan 30, 2017 at 04:19:56PM +0300, Denis V. Lunev wrote: >> From: Anton Nefedov >> >> According to RFC7230 Section 3.2, header field name is case-insensitive. >> >> The haystack string length is limited by 4096 bytes by >> qio_channel_webs

Re: [Qemu-devel] [PATCH 1/1] io: ignore case in WebSocket HTTP header #PSBM-57554

2017-02-27 Thread Daniel P. Berrange
On Mon, Jan 30, 2017 at 04:19:56PM +0300, Denis V. Lunev wrote: > From: Anton Nefedov > > According to RFC7230 Section 3.2, header field name is case-insensitive. > > The haystack string length is limited by 4096 bytes by > qio_channel_websock_handshake_read(). > > Further, handshake_process()

Re: [Qemu-devel] [PATCH 1/1] io: ignore case in WebSocket HTTP header #PSBM-57554

2017-01-30 Thread Denis V. Lunev
On 01/30/2017 06:47 PM, Daniel P. Berrange wrote: > What is #PSBM-57554 referring to ? Is that some custom bug tracker > you have ? I'm going to drop that unless its something we need to > keep it must be dropped. Sorry, this is my mistake. Den > On Mon, Jan 30, 2017 at 04:19:56PM +0300, Denis

Re: [Qemu-devel] [PATCH 1/1] io: ignore case in WebSocket HTTP header #PSBM-57554

2017-01-30 Thread Daniel P. Berrange
What is #PSBM-57554 referring to ? Is that some custom bug tracker you have ? I'm going to drop that unless its something we need to keep On Mon, Jan 30, 2017 at 04:19:56PM +0300, Denis V. Lunev wrote: > From: Anton Nefedov > > According to RFC7230 Section 3.2, header field name is case-insensi

[Qemu-devel] [PATCH 1/1] io: ignore case in WebSocket HTTP header #PSBM-57554

2017-01-30 Thread Denis V. Lunev
From: Anton Nefedov According to RFC7230 Section 3.2, header field name is case-insensitive. The haystack string length is limited by 4096 bytes by qio_channel_websock_handshake_read(). Further, handshake_process() dups and NULL-terminates the string so it is safe to call non length-limited fun