On Tue, Nov 20, 2012 at 12:22:59PM +0100, Christian Borntraeger wrote:
> On 19/11/12 15:11, Markus Armbruster wrote:
> I will try to review each place before re-submitting.
Nice. Besides the points that have been mentioned this looks like a
nice way to generalize. Looking forward to the next ser
On 19/11/12 15:11, Markus Armbruster wrote:
>
> Generalizing QEMUMachine member use_scsi to a default BlockInterfaceType
> makes plenty of sense to me.
Great.
>
> I'm not sure "no initializer means IDE" is such a hot idea, but since
> it's how use_scsi has always worked, I'm okay with making it
Alexander Graf writes:
> On 19.11.2012, at 14:44, Christian Borntraeger wrote:
>
>> On 19/11/12 14:36, Alexander Graf wrote:
>>>
>>> On 12.11.2012, at 09:22, Christian Borntraeger wrote:
>>>
There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
default/standard interface to
On 19.11.2012, at 14:44, Christian Borntraeger wrote:
> On 19/11/12 14:36, Alexander Graf wrote:
>>
>> On 12.11.2012, at 09:22, Christian Borntraeger wrote:
>>
>>> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
>>> default/standard interface to their block devices / drives. Th
On 19/11/12 14:36, Alexander Graf wrote:
>
> On 12.11.2012, at 09:22, Christian Borntraeger wrote:
>
>> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
>> default/standard interface to their block devices / drives. Therfore,
>> this patch introduces a new field default_block per
On 12.11.2012, at 09:22, Christian Borntraeger wrote:
> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
> default/standard interface to their block devices / drives. Therfore,
> this patch introduces a new field default_block per QEMUMachine struct.
> The prior use_scsi field bec
Should also have CCed the block maintainer...
On 12/11/12 09:22, Christian Borntraeger wrote:
> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
> default/standard interface to their block devices / drives. Therfore,
> this patch introduces a new field default_block per QEMUMachin
There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
default/standard interface to their block devices / drives. Therfore,
this patch introduces a new field default_block per QEMUMachine struct.
The prior use_scsi field becomes thereby obsolete and is replaced through
.default_block = D
