Re: [Qemu-devel] [PATCH 1/1] Revert "linux-aio: Cancel BH if not needed"

2016-06-28 Thread Stefan Hajnoczi
On Fri, Jun 24, 2016 at 3:46 PM, Kevin Wolf wrote: >> diff --git a/block/linux-aio.c b/block/linux-aio.c >> index e468960..fe7cece 100644 >> --- a/block/linux-aio.c >> +++ b/block/linux-aio.c >> @@ -149,8 +149,6 @@ static void qemu_laio_completion_bh(void *opaque) >> if (!s->io_q.plugged && !

Re: [Qemu-devel] [PATCH 1/1] Revert "linux-aio: Cancel BH if not needed"

2016-06-27 Thread Stefan Hajnoczi
On Fri, Jun 24, 2016 at 2:40 PM, Roman Pen wrote: > diff --git a/block/linux-aio.c b/block/linux-aio.c > index e468960..fe7cece 100644 > --- a/block/linux-aio.c > +++ b/block/linux-aio.c > @@ -149,8 +149,6 @@ static void qemu_laio_completion_bh(void *opaque) > if (!s->io_q.plugged && !QSIMPLE

Re: [Qemu-devel] [PATCH 1/1] Revert "linux-aio: Cancel BH if not needed"

2016-06-27 Thread Stefan Hajnoczi
On Fri, Jun 24, 2016 at 3:46 PM, Kevin Wolf wrote: > Am 24.06.2016 um 15:40 hat Roman Pen geschrieben: >> This reverts commit ccb9dc10129954d0bcd7814298ed445e684d5a2a, >> which causes MQ stuck while doing IO thru virtio_blk. > > It would be good to have a theory why this happens. It's worth takin

Re: [Qemu-devel] [PATCH 1/1] Revert "linux-aio: Cancel BH if not needed"

2016-06-24 Thread Kevin Wolf
Am 24.06.2016 um 15:40 hat Roman Pen geschrieben: > This reverts commit ccb9dc10129954d0bcd7814298ed445e684d5a2a, > which causes MQ stuck while doing IO thru virtio_blk. It would be good to have a theory why this happens. > diff --git a/block/linux-aio.c b/block/linux-aio.c > index e468960..fe7ce

[Qemu-devel] [PATCH 1/1] Revert "linux-aio: Cancel BH if not needed"

2016-06-24 Thread Roman Pen
This reverts commit ccb9dc10129954d0bcd7814298ed445e684d5a2a, which causes MQ stuck while doing IO thru virtio_blk. I reproduce very easily this stuck on recent v4 Stefan's set using num-queues=4: "[PATCH v4 0/7] virtio-blk: multiqueue support" https://lists.gnu.org/archive/html/qemu-devel/20