Re: [Qemu-devel] [PATCH 1/1] Make qemu-bridge-helper work in macOS and FreeBSD

2018-04-20 Thread Stefan Hajnoczi
On Tue, Apr 17, 2018 at 09:57:46AM +0530, Nikhil Balachandra wrote: > Hi Stefan, > > Thanks for the review. I'll be sending v2 version of this patch in next 3-4 > days with the following changes. > > 1) New scripts/update-xnu-headers.sh script to import if_bridgevar.h[4] > into include/standard-h

Re: [Qemu-devel] [PATCH 1/1] Make qemu-bridge-helper work in macOS and FreeBSD

2018-04-16 Thread Nikhil Balachandra
Hi Stefan, Thanks for the review. I'll be sending v2 version of this patch in next 3-4 days with the following changes. 1) New scripts/update-xnu-headers.sh script to import if_bridgevar.h[4] into include/standard-headers/xnu directory. @qemu-devel - Please let me know if there is a better ap

Re: [Qemu-devel] [PATCH 1/1] Make qemu-bridge-helper work in macOS and FreeBSD

2018-04-16 Thread Stefan Hajnoczi
On Sat, Apr 07, 2018 at 01:12:05AM +0530, Nikhil Balachandra wrote: > Eventhough macOS does not ship with the if_bridgevar.h header file[2], > I expect the API to remain stable as this header file is similar to what > is found in other BSDs. If this patch is decided to be included in the > qemu, ca

[Qemu-devel] [PATCH 1/1] Make qemu-bridge-helper work in macOS and FreeBSD

2018-04-06 Thread Nikhil Balachandra
Add macOS and FreeBSD support to the qemu-bridge-helper. Differences when compared to linux version. 1) Does no drop privileges at the start of the process and run as root throughout the lifetime of the process there by increasing the risk incase of security vulnerability. 2) Does not suppor