Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Juan Quintela
Paolo Bonzini wrote: > Il 21/03/2014 16:45, Dr. David Alan Gilbert ha scritto: >>> > So it looks like your patch could also fix the problem Juan reported >>> > at http://article.gmane.org/gmane.comp.emulators.qemu/247462 -- but >>> > perhaps only on hosts where !KVM || TARGET_PAGE_SIZE==getpagesiz

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Paolo Bonzini
Il 21/03/2014 16:45, Dr. David Alan Gilbert ha scritto: > So it looks like your patch could also fix the problem Juan reported > at http://article.gmane.org/gmane.comp.emulators.qemu/247462 -- but > perhaps only on hosts where !KVM || TARGET_PAGE_SIZE==getpagesize(). Possibly yes; I think that w

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 21/03/2014 14:22, Dr. David Alan Gilbert ha scritto: > >I don't think they overlap, but I worry that the end of one block > >and the start of the next might be on the same page. > >The code that got me worried was migration_bitmap_sync_range > >that

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Paolo Bonzini
Il 21/03/2014 14:22, Dr. David Alan Gilbert ha scritto: I don't think they overlap, but I worry that the end of one block and the start of the next might be on the same page. The code that got me worried was migration_bitmap_sync_range that seemd to be general; but actually that's worrying about

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Dr. David Alan Gilbert
* (chenliang0...@icloud.com) wrote: > > > From: "Dr. David Alan Gilbert" > > > > This is a fix for a bug* triggered by a migration after hot unplugging > > a few virtio-net NICs, that caused migration never to converge, because > > 'migration_dirty_pages' is incorrectly initialised. > > >

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread 陈梁
> From: "Dr. David Alan Gilbert" > > This is a fix for a bug* triggered by a migration after hot unplugging > a few virtio-net NICs, that caused migration never to converge, because > 'migration_dirty_pages' is incorrectly initialised. > > 'migration_dirty_pages' is used as a tally of the numbe

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > This is a fix for a bug* triggered by a migration after hot unplugging > > a few virtio-net NICs, that caused migration never to converge, because > > 'migration_dirty_p

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > This is a fix for a bug* triggered by a migration after hot unplugging > a few virtio-net NICs, that caused migration never to converge, because > 'migration_dirty_pages' is incorrectly initialised. Good catch. > 'migrat

[Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This is a fix for a bug* triggered by a migration after hot unplugging a few virtio-net NICs, that caused migration never to converge, because 'migration_dirty_pages' is incorrectly initialised. 'migration_dirty_pages' is used as a tally of the number of outstandin