Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-28 Thread Li Zhang
On Thu, Jun 28, 2012 at 9:22 PM, Alexander Graf wrote: > On 06/15/2012 02:46 PM, Li Zhang wrote: >> >> On Fri, Jun 15, 2012 at 7:09 PM, Andreas Färber  wrote: >>> >>> >>> You don't seem to be getting what I'm saying: As discussed in great >>> lengths for how to access a passed-in device tree for A

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-28 Thread Alexander Graf
On 06/15/2012 02:46 PM, Li Zhang wrote: On Fri, Jun 15, 2012 at 7:09 PM, Andreas Färber wrote: You don't seem to be getting what I'm saying: As discussed in great lengths for how to access a passed-in device tree for ARM, the code checking this option (i.e., in spapr.c) is expected to call qem

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-15 Thread Li Zhang
On Fri, Jun 15, 2012 at 7:09 PM, Andreas Färber wrote: > > Am 15.06.2012 05:06, schrieb Li Zhang: > > > > > > On Thu, Jun 14, 2012 at 10:27 PM, Andreas Färber > > wrote: > > > >     Am 14.06.2012 07:17, schrieb zhlci...@gmail.com > >     : > >  

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-15 Thread Andreas Färber
Am 15.06.2012 05:06, schrieb Li Zhang: > > > On Thu, Jun 14, 2012 at 10:27 PM, Andreas Färber > wrote: > > Am 14.06.2012 07:17, schrieb zhlci...@gmail.com > : > > From: Li Zhang > > > >

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-14 Thread Li Zhang
On Fri, Jun 15, 2012 at 1:15 PM, Peter Crosthwaite < peter.crosthwa...@petalogix.com> wrote: > On Fri, Jun 15, 2012 at 1:06 PM, Li Zhang wrote: > > > > > > On Thu, Jun 14, 2012 at 10:27 PM, Andreas Färber > wrote: > >> > >> Am 14.06.2012 07:17, schrieb zhlci...@gmail.com: > >> > From: Li Zhang

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-14 Thread Benjamin Herrenschmidt
On Fri, 2012-06-15 at 15:15 +1000, Peter Crosthwaite wrote: > > What should really happen here, is if you do change over to a machine > opt, then all clients of the -usb should use the machine opt > infrastructure, then the need for global state is eliminated > completely. > > But does this new -

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-14 Thread Peter Crosthwaite
On Fri, Jun 15, 2012 at 1:06 PM, Li Zhang wrote: > > > On Thu, Jun 14, 2012 at 10:27 PM, Andreas Färber wrote: >> >> Am 14.06.2012 07:17, schrieb zhlci...@gmail.com: >> > From: Li Zhang >> > >> > For pseries machine, it needs to enable usb >> > to add kbd or usb mouse. -usb option won't >> > be

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-14 Thread Li Zhang
On Thu, Jun 14, 2012 at 10:27 PM, Andreas Färber wrote: > Am 14.06.2012 07:17, schrieb zhlci...@gmail.com: > > From: Li Zhang > > > > For pseries machine, it needs to enable usb > > to add kbd or usb mouse. -usb option won't > > be used in the future, and machine options > > is a better way to e

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-14 Thread Li Zhang
OK,sorry for my fault. best regards Li Zhang 在 2012-6-15 上午6:05，"Benjamin Herrenschmidt" 写道： > > On Thu, 2012-06-14 at 16:27 +0200, Andreas Färber wrote: > > Am 14.06.2012 07:17, schrieb zhlci...@gmail.com: > > > From: Li Zhang > > > > > > For pseries machine, it needs to enable usb > > > to add

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-14 Thread Benjamin Herrenschmidt
On Thu, 2012-06-14 at 16:27 +0200, Andreas Färber wrote: > Am 14.06.2012 07:17, schrieb zhlci...@gmail.com: > > From: Li Zhang > > > > For pseries machine, it needs to enable usb > > to add kbd or usb mouse. -usb option won't > > be used in the future, and machine options > > is a better way to e

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-14 Thread Andreas Färber
Am 14.06.2012 07:17, schrieb zhlci...@gmail.com: > From: Li Zhang > > For pseries machine, it needs to enable usb > to add kbd or usb mouse. -usb option won't > be used in the future, and machine options > is a better way to enable usb. > > So this patch is to add usb option to machine > options

[Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-13 Thread zhlcindy
From: Li Zhang For pseries machine, it needs to enable usb to add kbd or usb mouse. -usb option won't be used in the future, and machine options is a better way to enable usb. So this patch is to add usb option to machine options (-machine type=psereis,usb=on/off) to enable/disable usb controlle