On 08/09/2011 11:44 AM, Avi Kivity wrote:
...isn't this just throwing away the warnings on bad-width accesses?
It is; will fix.
Reading the original code, it seems broken:
uint32_t omap_badwidth_read32(void *opaque, target_phys_addr_t addr)
{
uint32_t ret;
OMAP_32B_REG(addr);
c
On 08/09/2011 11:07 AM, Peter Maydell wrote:
On 9 August 2011 08:41, Avi Kivity wrote:
> On 08/09/2011 10:37 AM, Peter Maydell wrote:
>>
>> On 9 August 2011 07:34, Avi Kivitywrote:
>> >Also, my patchset focuses on mechanical transformations. It is already
>> >risky enough in ter
On 9 August 2011 08:41, Avi Kivity wrote:
> On 08/09/2011 10:37 AM, Peter Maydell wrote:
>>
>> On 9 August 2011 07:34, Avi Kivity wrote:
>> > Also, my patchset focuses on mechanical transformations. It is already
>> > risky enough in terms of regressions, I'm not going to rewrite/improve
>> >
On 08/09/2011 10:37 AM, Peter Maydell wrote:
On 9 August 2011 07:34, Avi Kivity wrote:
> Also, my patchset focuses on mechanical transformations. It is already
> risky enough in terms of regressions, I'm not going to rewrite/improve all
> of qemu; if you want those callbacks removed, you wil
On 9 August 2011 07:34, Avi Kivity wrote:
> Also, my patchset focuses on mechanical transformations. It is already
> risky enough in terms of regressions, I'm not going to rewrite/improve all
> of qemu; if you want those callbacks removed, you will have to remove them
> yourself.
Sure. Can I ask
On 08/08/2011 08:43 PM, Peter Maydell wrote:
On 8 August 2011 18:06, Avi Kivity wrote:
> Somewhat clumsy since it needs a variable sized region.
> @@ -119,7 +120,7 @@ void omap_sdrc_reset(struct omap_sdrc_s *s);
>struct omap_gpmc_s;
>struct omap_gpmc_s *omap_gpmc_init(target_phys_addr
On 8 August 2011 18:06, Avi Kivity wrote:
> Somewhat clumsy since it needs a variable sized region.
> @@ -119,7 +120,7 @@ void omap_sdrc_reset(struct omap_sdrc_s *s);
> struct omap_gpmc_s;
> struct omap_gpmc_s *omap_gpmc_init(target_phys_addr_t base, qemu_irq irq);
> void omap_gpmc_reset(struc
Somewhat clumsy since it needs a variable sized region.
Signed-off-by: Avi Kivity
---
hw/omap.h |3 ++-
hw/omap_gpmc.c | 53 +
hw/tusb6010.c | 30 +-
hw/tusb6010.h |7 +--
4 files changed, 49 i
