Re: [Qemu-devel] [PATCH 09/20] mirror: switch mirror_iteration to AIO

2012-12-15 Thread Eric Blake
On 12/15/2012 02:09 AM, Paolo Bonzini wrote: >>> +/* Allocate a MirrorOp that is used as an AIO callback. */ >>> +op = g_slice_new(MirrorOp); >>> +op->s = s; >>> +op->iov.iov_base = s->buf; >>> +op->iov.iov_len = nb_sectors * 512; >> >> Why two spaces? > > To align the equal

Re: [Qemu-devel] [PATCH 09/20] mirror: switch mirror_iteration to AIO

2012-12-15 Thread Paolo Bonzini
- Messaggio originale - > Da: "Eric Blake" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, kw...@redhat.com, stefa...@redhat.com, > jc...@redhat.com > Inviato: Venerdì, 14 dicembre 2012 23:11:02 > Oggetto: Re: [PATCH 09/20] mirror: switch mirror_iteration to AIO > > On 12/12/2012 06

Re: [Qemu-devel] [PATCH 09/20] mirror: switch mirror_iteration to AIO

2012-12-14 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > There is really no change in the behavior of the job here, since > there is still a maximum of one in-flight I/O operation between > the source and the target. However, this patch already introduces > the AIO callbacks (which are unmodified in the nex

[Qemu-devel] [PATCH 09/20] mirror: switch mirror_iteration to AIO

2012-12-12 Thread Paolo Bonzini
There is really no change in the behavior of the job here, since there is still a maximum of one in-flight I/O operation between the source and the target. However, this patch already introduces the AIO callbacks (which are unmodified in the next patch) and some of the logic to count in-flight ope