Re: [Qemu-devel] [PATCH 09/11] qmp.py: Avoid overriding a builtin object

2017-07-24 Thread Lukáš Doktor
Dne 21.7.2017 v 20:46 Eduardo Habkost napsal(a): > On Fri, Jul 21, 2017 at 08:53:49AM +0200, Lukáš Doktor wrote: >> Dne 20.7.2017 v 20:38 Eduardo Habkost napsal(a): >>> On Thu, Jul 20, 2017 at 06:28:13PM +0200, Lukáš Doktor wrote: The "id" is a builtin method to get object's identity and shoul

Re: [Qemu-devel] [PATCH 09/11] qmp.py: Avoid overriding a builtin object

2017-07-21 Thread Eduardo Habkost
On Fri, Jul 21, 2017 at 08:53:49AM +0200, Lukáš Doktor wrote: > Dne 20.7.2017 v 20:38 Eduardo Habkost napsal(a): > > On Thu, Jul 20, 2017 at 06:28:13PM +0200, Lukáš Doktor wrote: > >> The "id" is a builtin method to get object's identity and should not be > >> overridden. This might bring some issu

Re: [Qemu-devel] [PATCH 09/11] qmp.py: Avoid overriding a builtin object

2017-07-20 Thread Lukáš Doktor
Dne 20.7.2017 v 20:38 Eduardo Habkost napsal(a): > On Thu, Jul 20, 2017 at 06:28:13PM +0200, Lukáš Doktor wrote: >> The "id" is a builtin method to get object's identity and should not be >> overridden. This might bring some issues in case someone was directly >> calling "cmd(..., id=id)" but I hav

Re: [Qemu-devel] [PATCH 09/11] qmp.py: Avoid overriding a builtin object

2017-07-20 Thread Eduardo Habkost
On Thu, Jul 20, 2017 at 06:28:13PM +0200, Lukáš Doktor wrote: > The "id" is a builtin method to get object's identity and should not be > overridden. This might bring some issues in case someone was directly > calling "cmd(..., id=id)" but I haven't found such usage on brief search > for "cmd\(.*id

[Qemu-devel] [PATCH 09/11] qmp.py: Avoid overriding a builtin object

2017-07-20 Thread Lukáš Doktor
The "id" is a builtin method to get object's identity and should not be overridden. This might bring some issues in case someone was directly calling "cmd(..., id=id)" but I haven't found such usage on brief search for "cmd\(.*id=". Signed-off-by: Lukáš Doktor --- scripts/qmp/qmp.py | 8