Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-14 Thread Richard Henderson
On 04/14/2011 09:48 AM, Peter Maydell wrote: > Or the other approach would be to do something like > how the 'denormal-input-went-to-zero' case is handled: have > an extra float_flag for float_flag_output_denormal, and let > targets either (a) special-case it or (b) merge it with > whichever of und

Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-14 Thread Peter Maydell
On 14 April 2011 17:27, Richard Henderson wrote: > On 04/14/2011 08:39 AM, Peter Maydell wrote: >>>  Exponent underflow and disabled: >>>    Supply +0, no exception delivered to user. >>> >>>  Exponent underflow and enabled: >>>    Supply +-MIN denorm, Underflow delivered to user. >>> >>>    Footn

Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-14 Thread Richard Henderson
On 04/14/2011 08:39 AM, Peter Maydell wrote: >> Exponent underflow and disabled: >>Supply +0, no exception delivered to user. >> >> Exponent underflow and enabled: >>Supply +-MIN denorm, Underflow delivered to user. >> >>Footnote 3, Overflow and Underflow have priority over Inexact. >

Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-14 Thread Peter Maydell
On 14 April 2011 16:14, Richard Henderson wrote: > On 04/14/2011 02:14 AM, Peter Maydell wrote: >> While we're on the subject of Alpha and flush-to-zero modes, >> do you know what exception bits should get set when Alpha >> flushes a denormal output (not input) to zero? > ... >> I think Alpha shou

Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-14 Thread Richard Henderson
On 04/14/2011 02:14 AM, Peter Maydell wrote: > While we're on the subject of Alpha and flush-to-zero modes, > do you know what exception bits should get set when Alpha > flushes a denormal output (not input) to zero? ... > I think Alpha should set Inexact and not Underflow, but > I'm not sure -- ca

Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-14 Thread Peter Maydell
On 13 April 2011 16:38, Richard Henderson wrote: > (It looks like some of the Alpha code can be cleaned up a bit. > I don't recall flush_inputs_to_zero option being there before, > and we do that by hand in helper_ieee_input*.) While we're on the subject of Alpha and flush-to-zero modes, do you k

Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-13 Thread Aurelien Jarno
On Wed, Apr 13, 2011 at 08:53:27AM -0700, Richard Henderson wrote: > On 04/13/2011 08:42 AM, Peter Maydell wrote: > > On 13 April 2011 16:38, Richard Henderson wrote: > >> [ Odd, the original thread doesn't seem to have arrived here. ] > >> > >> On 04/13/2011 07:52 AM, Peter Maydell wrote: > >>> S

Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-13 Thread Richard Henderson
[ Odd, the original thread doesn't seem to have arrived here. ] On 04/13/2011 07:52 AM, Peter Maydell wrote: > So I think you want the _quiet version here. (And helper_cmpteq > needs to use float64_eq_quiet rather than float64_eq.) Yes, the _quiet version is what's needed for all comparisons. Fo

Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-13 Thread Richard Henderson
On 04/13/2011 08:42 AM, Peter Maydell wrote: > On 13 April 2011 16:38, Richard Henderson wrote: >> [ Odd, the original thread doesn't seem to have arrived here. ] >> >> On 04/13/2011 07:52 AM, Peter Maydell wrote: >>> So I think you want the _quiet version here. (And helper_cmpteq >>> needs to use

Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-13 Thread Peter Maydell
On 13 April 2011 16:38, Richard Henderson wrote: > [ Odd, the original thread doesn't seem to have arrived here. ] > > On 04/13/2011 07:52 AM, Peter Maydell wrote: >> So I think you want the _quiet version here. (And helper_cmpteq >> needs to use float64_eq_quiet rather than float64_eq.) > > Yes,

Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-13 Thread Peter Maydell
On 12 April 2011 22:59, Aurelien Jarno wrote: > Use float64_unordered() in helper_cmptun() instead of doing the > the comparison manually. This also fixes the wrong behaviours with > sNaNs. > > Signed-off-by: Aurelien Jarno > --- >  target-alpha/op_helper.c |    5 +++-- >  1 files changed, 3 inse

[Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-12 Thread Aurelien Jarno
Use float64_unordered() in helper_cmptun() instead of doing the the comparison manually. This also fixes the wrong behaviours with sNaNs. Signed-off-by: Aurelien Jarno --- target-alpha/op_helper.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target-alpha/op_helper