Re: [Qemu-devel] [PATCH 08/18] qdict qlist: Make most helper macros functions

2018-01-31 Thread Markus Armbruster
Eric Blake writes: > On 01/30/2018 04:21 AM, Markus Armbruster wrote: >> The macro expansions of qdict_put_TYPE() and qlist_append_TYPE() need >> qbool.h, qnull.h, qnum.h and qstring.h to compile. We include qnull.h >> and qnum.h in the headers, but not qbool.h and qstring.h. Works, >> because

Re: [Qemu-devel] [PATCH 08/18] qdict qlist: Make most helper macros functions

2018-01-30 Thread Eric Blake
On 01/30/2018 04:21 AM, Markus Armbruster wrote: > The macro expansions of qdict_put_TYPE() and qlist_append_TYPE() need > qbool.h, qnull.h, qnum.h and qstring.h to compile. We include qnull.h > and qnum.h in the headers, but not qbool.h and qstring.h. Works, > because we include those wherever t

[Qemu-devel] [PATCH 08/18] qdict qlist: Make most helper macros functions

2018-01-30 Thread Markus Armbruster
The macro expansions of qdict_put_TYPE() and qlist_append_TYPE() need qbool.h, qnull.h, qnum.h and qstring.h to compile. We include qnull.h and qnum.h in the headers, but not qbool.h and qstring.h. Works, because we include those wherever the macros get used. Open-coding these helpers is of dubi