Re: [Qemu-devel] [PATCH 08/13] be-hci: use backend functions

2017-05-28 Thread andrzej zaborowski
On 26 May 2017 at 14:20, Marc-André Lureau wrote: > On Tue, May 9, 2017 at 3:42 PM Marc-André Lureau < > marcandre.lur...@redhat.com> wrote: >> Avoid accessing CharBackend directly, use qemu_chr_be_* methods instead. >> >> be->chr_read should exists if qemu_chr_be_can_write() is true. >> >> (use q

Re: [Qemu-devel] [PATCH 08/13] be-hci: use backend functions

2017-05-26 Thread Philippe Mathieu-Daudé
Hi Marc-André, On 05/09/2017 08:33 AM, Marc-André Lureau wrote: Avoid accessing CharBackend directly, use qemu_chr_be_* methods instead. be->chr_read should exists if qemu_chr_be_can_write() is true. (use qemu_chr_be_write(), _impl() bypasses replay) Signed-off-by: Marc-André Lureau --- hw/

Re: [Qemu-devel] [PATCH 08/13] be-hci: use backend functions

2017-05-26 Thread Marc-André Lureau
On Tue, May 9, 2017 at 3:42 PM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Avoid accessing CharBackend directly, use qemu_chr_be_* methods instead. > > be->chr_read should exists if qemu_chr_be_can_write() is true. > > (use qemu_chr_be_write(), _impl() bypasses replay) > > Signed-off

[Qemu-devel] [PATCH 08/13] be-hci: use backend functions

2017-05-09 Thread Marc-André Lureau
Avoid accessing CharBackend directly, use qemu_chr_be_* methods instead. be->chr_read should exists if qemu_chr_be_can_write() is true. (use qemu_chr_be_write(), _impl() bypasses replay) Signed-off-by: Marc-André Lureau --- hw/bt/hci-csr.c | 9 +++-- 1 file changed, 3 insertions(+), 6 dele