Re: [Qemu-devel] [PATCH 08/12] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1

2011-07-02 Thread Blue Swirl
On Sat, Jul 2, 2011 at 1:02 PM, Andreas Färber wrote: > Am 02.07.2011 um 11:04 schrieb Blue Swirl: > >> On Sat, Jul 2, 2011 at 12:06 AM, malc wrote: >>> >>> On Sat, 2 Jul 2011, Blue Swirl wrote: >>> On Tue, Jun 28, 2011 at 1:51 AM, malc wrote: > > On Sun, 26 Jun 2011, Blue Swirl wro

Re: [Qemu-devel] [PATCH 08/12] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1

2011-07-02 Thread Andreas Färber
Am 02.07.2011 um 11:04 schrieb Blue Swirl: On Sat, Jul 2, 2011 at 12:06 AM, malc wrote: On Sat, 2 Jul 2011, Blue Swirl wrote: On Tue, Jun 28, 2011 at 1:51 AM, malc wrote: On Sun, 26 Jun 2011, Blue Swirl wrote: Use TCG_REG_CALL_STACK instead of TCG_REG_R1 etc. for consistency. This i'd

Re: [Qemu-devel] [PATCH 08/12] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1

2011-07-02 Thread Blue Swirl
On Sat, Jul 2, 2011 at 12:06 AM, malc wrote: > On Sat, 2 Jul 2011, Blue Swirl wrote: > >> On Tue, Jun 28, 2011 at 1:51 AM, malc wrote: >> > On Sun, 26 Jun 2011, Blue Swirl wrote: >> > >> >> Use TCG_REG_CALL_STACK instead of TCG_REG_R1 etc. for consistency. >> >> >> > >> > This i'd rather avoid. >

Re: [Qemu-devel] [PATCH 08/12] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1

2011-07-01 Thread malc
On Sat, 2 Jul 2011, Blue Swirl wrote: > On Tue, Jun 28, 2011 at 1:51 AM, malc wrote: > > On Sun, 26 Jun 2011, Blue Swirl wrote: > > > >> Use TCG_REG_CALL_STACK instead of TCG_REG_R1 etc. for consistency. > >> > > > > This i'd rather avoid. > > Why? In addition to the consistency among targets, a

Re: [Qemu-devel] [PATCH 08/12] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1

2011-07-01 Thread Blue Swirl
On Tue, Jun 28, 2011 at 1:51 AM, malc wrote: > On Sun, 26 Jun 2011, Blue Swirl wrote: > >> Use TCG_REG_CALL_STACK instead of TCG_REG_R1 etc. for consistency. >> > > This i'd rather avoid. Why? In addition to the consistency among targets, a magic constant is replaced with a symbol which improves

Re: [Qemu-devel] [PATCH 08/12] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1

2011-06-27 Thread malc
On Sun, 26 Jun 2011, Blue Swirl wrote: > Use TCG_REG_CALL_STACK instead of TCG_REG_R1 etc. for consistency. > This i'd rather avoid. [..snip..] -- mailto:av1...@comtv.ru

[Qemu-devel] [PATCH 08/12] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1

2011-06-26 Thread Blue Swirl
Use TCG_REG_CALL_STACK instead of TCG_REG_R1 etc. for consistency. Signed-off-by: Blue Swirl --- tcg/ppc/tcg-target.c | 18 +++--- tcg/ppc64/tcg-target.c | 16 +--- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-t