On 08/22/2011 01:59 PM, Stefan Hajnoczi wrote:
> +DEFINE_PROP_INT32("fd", GoldfishMemlogDevice, fd, -1),
I'm not sure these fields all need to be defined here. Why make fd a
qdev property?
I agree fd doesn't make much sense, but we may want to make it a chardev.
Paolo
On Mon, Aug 22, 2011 at 10:39 AM, Patrick Jackson
wrote:
> +static void memlog_write(void *opaque, target_phys_addr_t offset, uint32_t
> val)
> +{
> + static unsigned info[8];
The size should be 2, not 8.
Using a static variable is a bit lazy here. We're already accessing
GoldfishMemlogDevic
Signed-off-by: Patrick Jackson
---
Makefile.target |2 +-
hw/android_arm.c |1 +
hw/goldfish_device.h |1 +
hw/goldfish_memlog.c | 106
++
4 files changed, 109 insertions(+), 1 deletions(-)
create mode 100644 hw/goldfish_memlo
