Re: [Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation

2016-06-06 Thread Michael Rolnik
On Mon, Jun 6, 2016 at 10:17 PM, Richard Henderson wrote: > On 06/05/2016 11:52 PM, Michael Rolnik wrote: > >> truth table shows that these computations are different. >> > > You're not giving the right inputs to the truth table. > > you can't look onto 4th bit because 4th bits in the input were

Re: [Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation

2016-06-06 Thread Richard Henderson
On 06/05/2016 11:52 PM, Michael Rolnik wrote: truth table shows that these computations are different. You're not giving the right inputs to the truth table. you can't look onto 4th bit because 4th bits in the input were not 0s. What did you think the xor's do? They remove the non-zero inp

Re: [Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation

2016-06-05 Thread Michael Rolnik
On Mon, Jun 6, 2016 at 2:34 AM, Richard Henderson wrote: > On 06/05/2016 02:47 PM, Michael Rolnik wrote: > >> Is there a reason this code isn't going into translate.c? >> You wouldn't need the declarations in translate-inst.h or translate.h. >> >> I see here two levels of logic >> a. inst

Re: [Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation

2016-06-05 Thread Richard Henderson
On 06/05/2016 02:47 PM, Michael Rolnik wrote: Is there a reason this code isn't going into translate.c? You wouldn't need the declarations in translate-inst.h or translate.h. I see here two levels of logic a. instruction translation b. general flow of program translation. FWIW, static

Re: [Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation

2016-06-05 Thread Michael Rolnik
please see my answer inside. On Sun, Jun 5, 2016 at 6:27 AM, Richard Henderson wrote: > On 06/02/2016 01:07 PM, Michael Rolnik wrote: > >> Signed-off-by: Michael Rolnik >> --- >> target-avr/translate-inst.c | 2443 >> +++ >> > > Is there a reason this cod

Re: [Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation

2016-06-04 Thread Richard Henderson
On 06/02/2016 01:07 PM, Michael Rolnik wrote: Signed-off-by: Michael Rolnik --- target-avr/translate-inst.c | 2443 +++ Is there a reason this code isn't going into translate.c? You wouldn't need the declarations in translate-inst.h or translate.h. +/*

[Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/translate-inst.c | 2443 +++ target-avr/translate.h | 123 +++ 2 files changed, 2566 insertions(+) create mode 100644 target-avr/translate-inst.c create mode 100644 target-avr/translate.h diff --git a/ta

[Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/translate-inst.c | 2443 +++ target-avr/translate.h | 123 +++ 2 files changed, 2566 insertions(+) create mode 100644 target-avr/translate-inst.c create mode 100644 target-avr/translate.h diff --git a/ta