Re: [Qemu-devel] [PATCH 08/10] block: Reuse bs->options setting from bdrv_open()

2014-01-31 Thread Max Reitz
On 29.01.2014 14:45, Kevin Wolf wrote: Am 26.01.2014 um 20:02 hat Max Reitz geschrieben: Setting bs->options in bdrv_file_open() is not necessary if it is already done in bdrv_open(). Signed-off-by: Max Reitz Perhaps squash this into patch 7? Because now the reference is created by bdrv_open(

Re: [Qemu-devel] [PATCH 08/10] block: Reuse bs->options setting from bdrv_open()

2014-01-29 Thread Kevin Wolf
Am 26.01.2014 um 20:02 hat Max Reitz geschrieben: > Setting bs->options in bdrv_file_open() is not necessary if it is > already done in bdrv_open(). > > Signed-off-by: Max Reitz Perhaps squash this into patch 7? Because now the reference is created by bdrv_open() instead of bdrv_file_open(). Al

Re: [Qemu-devel] [PATCH 08/10] block: Reuse bs->options setting from bdrv_open()

2014-01-26 Thread Benoît Canet
Le Sunday 26 Jan 2014 à 20:02:41 (+0100), Max Reitz a écrit : > Setting bs->options in bdrv_file_open() is not necessary if it is > already done in bdrv_open(). > > Signed-off-by: Max Reitz > --- > block.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/block.c

[Qemu-devel] [PATCH 08/10] block: Reuse bs->options setting from bdrv_open()

2014-01-26 Thread Max Reitz
Setting bs->options in bdrv_file_open() is not necessary if it is already done in bdrv_open(). Signed-off-by: Max Reitz --- block.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index 0f2cd3f..f847c4b 100644 --- a/block.c +++ b/block.c @@ -956,9 +