Re: [Qemu-devel] [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro

2017-07-18 Thread Philippe Mathieu-Daudé
On Tue, Jul 18, 2017 at 7:23 AM, Alastair D'Silva wrote: > I'm not sure this makes sense - we're dealing with time here. Indeed, thanks for your review! >> --- a/hw/timer/ds1338.c >> +++ b/hw/timer/ds1338.c >> @@ -65,7 +65,7 @@ static void capture_current_time(DS1338State *s) >> s->nvram[1]

Re: [Qemu-devel] [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro

2017-07-18 Thread Alastair D'Silva
I'm not sure this makes sense - we're dealing with time here. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva msn: alast...@d-silva.org blog: http://alastair.d-silva.orgTwitter: @EvilDeece > -Original Message- > From: Philippe Mathieu-Daudé [mailto:philip

[Qemu-devel] [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro

2017-07-17 Thread Philippe Mathieu-Daudé
Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/ds1338.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/timer/ds1338.c b/hw/timer/ds1338.c index 3849b74a68..a77fe14514 100644 --- a/hw/ti