On Tue, Aug 22, 2017 at 06:52:19PM +0200, Markus Armbruster wrote:
> Marc-André Lureau writes:
[...]
> >>> +def func_wrapper(self, *args, **kwargs):
> >>> +funcname = self.__class__.__name__ + '.' + func.__name__
> >>> +ifcond = args[-1]
> >>> +save = {}
> >>> +
Marc-André Lureau writes:
> Hi
>
> On Wed, Aug 16, 2017 at 5:43 PM, Markus Armbruster wrote:
>> Marc-André Lureau writes:
>>
>>> Add 'if' c-preprocessor condition on top-level schema elements:
>>> struct, enum, union, alternate, command, event.
>>
>> An example would be useful here. Your cover
Hi
On Wed, Aug 16, 2017 at 5:43 PM, Markus Armbruster wrote:
> Marc-André Lureau writes:
>
>> Add 'if' c-preprocessor condition on top-level schema elements:
>> struct, enum, union, alternate, command, event.
>
> An example would be useful here. Your cover letter has nice ones, would
> be a sha
Marc-André Lureau writes:
> Add 'if' c-preprocessor condition on top-level schema elements:
> struct, enum, union, alternate, command, event.
>
> Variants objects types are created outside of #if blocks, since they
> may be shared by various types. Even if unused, this shouldn't be an
> issue, si
Markus Armbruster writes:
[...]
> Out of review brainpower for today. Hope to resume tomorrow.
>
> [...]
Nope, I'm giving up on this one. Please split it for reviewability.
Suggested split:
1. Preparatory refactoring for step 2, step by step
2. Frontend part: accept and check 'if', step by s
Marc-André Lureau writes:
> Add 'if' c-preprocessor condition on top-level schema elements:
> struct, enum, union, alternate, command, event.
An example would be useful here. Your cover letter has nice ones, would
be a shame not to preserve them for posterity in the commit log.
> Variants obje
Add 'if' c-preprocessor condition on top-level schema elements:
struct, enum, union, alternate, command, event.
Variants objects types are created outside of #if blocks, since they
may be shared by various types. Even if unused, this shouldn't be an
issue, since those are internal types.
Note tha
