- Messaggio originale -
> Da: "Paolo Bonzini"
> A: "Andreas Färber"
> Cc: "Jan Kiszka" , aligu...@us.ibm.com,
> qemu-devel@nongnu.org
> Inviato: Mercoledì, 16 maggio 2012 9:40:12
> Oggetto: Re: [Qemu-devel] [PATCH 07/25] qdev: use
> Am 03.04.2012 15:05, schrieb Paolo Bonzini:
> > Il 03/04/2012 14:28, Jan Kiszka ha scritto:
> if (object_property_get_type(OBJECT(dev), legacy_name,
> NULL)) {
> value = object_property_get_str(OBJECT(dev),
> legacy_name, &err);
> >>
Am 03.04.2012 15:05, schrieb Paolo Bonzini:
> Il 03/04/2012 14:28, Jan Kiszka ha scritto:
if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) {
value = object_property_get_str(OBJECT(dev), legacy_name,
&err);
>> This is not a criticism on this patch,
Am 11.05.2012 13:28, schrieb Paolo Bonzini:
> Il 10/05/2012 22:58, Jan Kiszka ha scritto:
>> Otherwise, non-string properties without a legacy counterpart are missed.
>> Also fix error propagation in object_property_print itself, otherwise
>> pointer properties are printed as "".
>>
Il 10/05/2012 22:58, Jan Kiszka ha scritto:
>>> >> Otherwise, non-string properties without a legacy counterpart are missed.
>>> >> Also fix error propagation in object_property_print itself, otherwise
>>> >> pointer properties are printed as "".
>>> >>
>>> >> Signed-off-by: Paolo Bonzini
>> >
>>
On 2012-04-03 18:06, Anthony Liguori wrote:
> On 04/03/2012 06:15 AM, Paolo Bonzini wrote:
>> Otherwise, non-string properties without a legacy counterpart are missed.
>> Also fix error propagation in object_property_print itself, otherwise
>> pointer properties are printed as "".
>>
>> Signed-off-
On 04/03/2012 06:15 AM, Paolo Bonzini wrote:
Otherwise, non-string properties without a legacy counterpart are missed.
Also fix error propagation in object_property_print itself, otherwise
pointer properties are printed as "".
Signed-off-by: Paolo Bonzini
Reviewed-by: Anthony Liguori
Regards
Il 03/04/2012 14:28, Jan Kiszka ha scritto:
>> > if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) {
>> > value = object_property_get_str(OBJECT(dev), legacy_name,
>> > &err);
> This is not a criticism on this patch, but I'd like to underline that
> the line above
On 2012-04-03 13:15, Paolo Bonzini wrote:
> Otherwise, non-string properties without a legacy counterpart are missed.
> Also fix error propagation in object_property_print itself, otherwise
> pointer properties are printed as "".
>
> Signed-off-by: Paolo Bonzini
> ---
> hw/qdev-monitor.c |2
Otherwise, non-string properties without a legacy counterpart are missed.
Also fix error propagation in object_property_print itself, otherwise
pointer properties are printed as "".
Signed-off-by: Paolo Bonzini
---
hw/qdev-monitor.c |2 +-
qom/object.c |2 +-
2 files changed, 2 inse
10 matches
Mail list logo
