Re: [Qemu-devel] [PATCH 07/20] target/openrisc: Form the spr index from tcg

2018-05-27 Thread Richard Henderson
On 05/27/2018 08:31 PM, Philippe Mathieu-Daudé wrote: > On 05/27/2018 11:13 AM, Richard Henderson wrote: >> Rather than pass base+offset to the helper, pass the full index. >> In most cases the base is r0 and optimization yields a constant. > > and while here you use generic TCGv instead of 32bit

Re: [Qemu-devel] [PATCH 07/20] target/openrisc: Form the spr index from tcg

2018-05-27 Thread Philippe Mathieu-Daudé
On 05/27/2018 11:13 AM, Richard Henderson wrote: > Rather than pass base+offset to the helper, pass the full index. > In most cases the base is r0 and optimization yields a constant. and while here you use generic TCGv instead of 32bit version. > > Signed-off-by: Richard Henderson Reviewed-by:

[Qemu-devel] [PATCH 07/20] target/openrisc: Form the spr index from tcg

2018-05-27 Thread Richard Henderson
Rather than pass base+offset to the helper, pass the full index. In most cases the base is r0 and optimization yields a constant. Signed-off-by: Richard Henderson --- target/openrisc/helper.h | 4 ++-- target/openrisc/sys_helper.c | 9 +++-- target/openrisc/translate.c | 16 +-